| Message ID | a9970cfc5eef360f6eff8cd24b41f50c07c1d744.1676207936.git.anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: btrfs/249, add _wants_kernel_commit | expand |
On Mon, Feb 13, 2023 at 9:58 AM Anand Jain <anand.jain@oracle.com> wrote: > > Add the _wants_kernel_commit tag for the benifit of testing on the older > kernels. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > tests/btrfs/249 | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/btrfs/249 b/tests/btrfs/249 > index 7cc4996e387b..1b79e52dbe05 100755 > --- a/tests/btrfs/249 > +++ b/tests/btrfs/249 > @@ -13,7 +13,7 @@ > # Dump 'btrfs filesystem usage', check it didn't fail > # > # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch > -# btrfs: sysfs add devinfo/fsid to retrieve fsid from the device > +# btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device > # btrfs-progs: read fsid from the sysfs in device_is_seed > > . ./common/preamble > @@ -29,6 +29,8 @@ _supported_fs btrfs > _require_scratch_dev_pool 3 > _require_command "$WIPEFS_PROG" wipefs > _require_btrfs_forget_or_module_loadable > +_wants_kernel_commit a26d60dedf9a \ > + "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device" There's a btrfs-progs patch listed above, so you can also add a: _fixed_by_git_commit btrfs-progs xxxxxxxxxxxx "btrfs-progs: read fsid from the sysfs in device_is_seed" And with that, you can then remove the comment above with the patch subjects, as it becomes redundant and pointless. Thanks. > > _scratch_dev_pool_get 2 > # use the scratch devices as seed devices > -- > 2.31.1 >
On Mon, Feb 13, 2023 at 05:45:09PM +0800, Anand Jain wrote: > Add the _wants_kernel_commit tag for the benifit of testing on the older > kernels. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- Besides this patch, you just sent another patchset: [PATCH 0/3] fstests: btrfs- add _fixed_by for new tests in the auto group which try to add _fixed_by for some btrfs cases. I think we don't need to "fix" these things one by one, by lots of small patch pieces. If there's not special reason (e.g. someone case need more fix besides adding _fixed_by), how about combine them into one patch which "clarify the _fixed_by or _wants commits for btrfs cases (or only for someone group)" Thanks, Zorro > tests/btrfs/249 | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/btrfs/249 b/tests/btrfs/249 > index 7cc4996e387b..1b79e52dbe05 100755 > --- a/tests/btrfs/249 > +++ b/tests/btrfs/249 > @@ -13,7 +13,7 @@ > # Dump 'btrfs filesystem usage', check it didn't fail > # > # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch > -# btrfs: sysfs add devinfo/fsid to retrieve fsid from the device > +# btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device > # btrfs-progs: read fsid from the sysfs in device_is_seed > > . ./common/preamble > @@ -29,6 +29,8 @@ _supported_fs btrfs > _require_scratch_dev_pool 3 > _require_command "$WIPEFS_PROG" wipefs > _require_btrfs_forget_or_module_loadable > +_wants_kernel_commit a26d60dedf9a \ > + "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device" > > _scratch_dev_pool_get 2 > # use the scratch devices as seed devices > -- > 2.31.1 >
On 2/14/23 14:17, Zorro Lang wrote: > On Mon, Feb 13, 2023 at 05:45:09PM +0800, Anand Jain wrote: >> Add the _wants_kernel_commit tag for the benifit of testing on the older >> kernels. >> >> Signed-off-by: Anand Jain <anand.jain@oracle.com> >> --- > > Besides this patch, you just sent another patchset: > [PATCH 0/3] fstests: btrfs- add _fixed_by for new tests in the auto group > which try to add _fixed_by for some btrfs cases. > Recently, these were added to the auto group. > I think we don't need to "fix" these things one by one, by lots of small patch > pieces. ok. > If there's not special reason (e.g. someone case need more fix besides > adding _fixed_by), how about combine them into one patch which "clarify the > _fixed_by or _wants commits for btrfs cases (or only for someone group)" > Hmm. btrfs/249 needs _wants_kernel_commit; btrfs/198, btrfs/185, and btrfs/219 need _fixed_by_kernel_commit. Merge the latter and send as one patch? Thanks, Anand > Thanks, > Zorro > >> tests/btrfs/249 | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/tests/btrfs/249 b/tests/btrfs/249 >> index 7cc4996e387b..1b79e52dbe05 100755 >> --- a/tests/btrfs/249 >> +++ b/tests/btrfs/249 >> @@ -13,7 +13,7 @@ >> # Dump 'btrfs filesystem usage', check it didn't fail >> # >> # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch >> -# btrfs: sysfs add devinfo/fsid to retrieve fsid from the device >> +# btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device >> # btrfs-progs: read fsid from the sysfs in device_is_seed >> >> . ./common/preamble >> @@ -29,6 +29,8 @@ _supported_fs btrfs >> _require_scratch_dev_pool 3 >> _require_command "$WIPEFS_PROG" wipefs >> _require_btrfs_forget_or_module_loadable >> +_wants_kernel_commit a26d60dedf9a \ >> + "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device" >> >> _scratch_dev_pool_get 2 >> # use the scratch devices as seed devices >> -- >> 2.31.1 >> >
On 2/13/23 19:56, Filipe Manana wrote: > On Mon, Feb 13, 2023 at 9:58 AM Anand Jain <anand.jain@oracle.com> wrote: >> >> Add the _wants_kernel_commit tag for the benifit of testing on the older >> kernels. >> >> Signed-off-by: Anand Jain <anand.jain@oracle.com> >> --- >> tests/btrfs/249 | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/tests/btrfs/249 b/tests/btrfs/249 >> index 7cc4996e387b..1b79e52dbe05 100755 >> --- a/tests/btrfs/249 >> +++ b/tests/btrfs/249 >> @@ -13,7 +13,7 @@ >> # Dump 'btrfs filesystem usage', check it didn't fail >> # >> # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch >> -# btrfs: sysfs add devinfo/fsid to retrieve fsid from the device >> +# btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device >> # btrfs-progs: read fsid from the sysfs in device_is_seed >> >> . ./common/preamble >> @@ -29,6 +29,8 @@ _supported_fs btrfs >> _require_scratch_dev_pool 3 >> _require_command "$WIPEFS_PROG" wipefs >> _require_btrfs_forget_or_module_loadable >> +_wants_kernel_commit a26d60dedf9a \ >> + "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device" > > There's a btrfs-progs patch listed above, so you can also add a: > > _fixed_by_git_commit btrfs-progs xxxxxxxxxxxx "btrfs-progs: read fsid > from the sysfs in device_is_seed" > > And with that, you can then remove the comment above with the patch > subjects, as it becomes redundant and pointless. > Got it. Fixing in v2. Thanks. > Thanks. > >> >> _scratch_dev_pool_get 2 >> # use the scratch devices as seed devices >> -- >> 2.31.1 >>
On Wed, Feb 15, 2023 at 12:34:14AM +0800, Anand Jain wrote: > On 2/14/23 14:17, Zorro Lang wrote: > > On Mon, Feb 13, 2023 at 05:45:09PM +0800, Anand Jain wrote: > > > Add the _wants_kernel_commit tag for the benifit of testing on the older > > > kernels. > > > > > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > > > --- > > > > Besides this patch, you just sent another patchset: > > [PATCH 0/3] fstests: btrfs- add _fixed_by for new tests in the auto group > > which try to add _fixed_by for some btrfs cases. > > > > Recently, these were added to the auto group. > > > I think we don't need to "fix" these things one by one, by lots of small patch > > pieces. > > ok. > > > If there's not special reason (e.g. someone case need more fix besides > > adding _fixed_by), how about combine them into one patch which "clarify the > > _fixed_by or _wants commits for btrfs cases (or only for someone group)" > > > > Hmm. > btrfs/249 needs _wants_kernel_commit; btrfs/198, btrfs/185, and > btrfs/219 need _fixed_by_kernel_commit. Merge the latter and > send as one patch? Either one or two patch are good to me, just don't need to one patch only add one _fixed_by/_wants :) Thanks, Zorro > > Thanks, Anand > > > > Thanks, > > Zorro > > > > > tests/btrfs/249 | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/tests/btrfs/249 b/tests/btrfs/249 > > > index 7cc4996e387b..1b79e52dbe05 100755 > > > --- a/tests/btrfs/249 > > > +++ b/tests/btrfs/249 > > > @@ -13,7 +13,7 @@ > > > # Dump 'btrfs filesystem usage', check it didn't fail > > > # > > > # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch > > > -# btrfs: sysfs add devinfo/fsid to retrieve fsid from the device > > > +# btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device > > > # btrfs-progs: read fsid from the sysfs in device_is_seed > > > . ./common/preamble > > > @@ -29,6 +29,8 @@ _supported_fs btrfs > > > _require_scratch_dev_pool 3 > > > _require_command "$WIPEFS_PROG" wipefs > > > _require_btrfs_forget_or_module_loadable > > > +_wants_kernel_commit a26d60dedf9a \ > > > + "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device" > > > _scratch_dev_pool_get 2 > > > # use the scratch devices as seed devices > > > -- > > > 2.31.1 > > > > > >
diff --git a/tests/btrfs/249 b/tests/btrfs/249 index 7cc4996e387b..1b79e52dbe05 100755 --- a/tests/btrfs/249 +++ b/tests/btrfs/249 @@ -13,7 +13,7 @@ # Dump 'btrfs filesystem usage', check it didn't fail # # Tests btrfs-progs bug fixed by the kernel patch and a btrfs-prog patch -# btrfs: sysfs add devinfo/fsid to retrieve fsid from the device +# btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device # btrfs-progs: read fsid from the sysfs in device_is_seed . ./common/preamble @@ -29,6 +29,8 @@ _supported_fs btrfs _require_scratch_dev_pool 3 _require_command "$WIPEFS_PROG" wipefs _require_btrfs_forget_or_module_loadable +_wants_kernel_commit a26d60dedf9a \ + "btrfs: sysfs: add devinfo/fsid to retrieve actual fsid from the device" _scratch_dev_pool_get 2 # use the scratch devices as seed devices
Add the _wants_kernel_commit tag for the benifit of testing on the older kernels. Signed-off-by: Anand Jain <anand.jain@oracle.com> --- tests/btrfs/249 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)