| Message ID | bd80e5861da3f901428ea66f271f8c4f267c4c23.1651158291.git.josef@toxicpanda.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: add some missing _require_loop's | expand |
On Thu, Apr 28, 2022 at 11:05:00AM -0400, Josef Bacik wrote: > Got a new box running overnight fstests and noticed a couple of failures > because I forgot to enable loop device support. Fix these two tests to > have _require_loop so they don't fail if there's no loop device support. > > Signed-off-by: Josef Bacik <josef@toxicpanda.com> Yep, these both use loop mounts. Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > tests/btrfs/012 | 1 + > tests/generic/648 | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/tests/btrfs/012 b/tests/btrfs/012 > index 29552b14..60461a34 100755 > --- a/tests/btrfs/012 > +++ b/tests/btrfs/012 > @@ -30,6 +30,7 @@ _require_command "$MKFS_EXT4_PROG" mkfs.ext4 > _require_command "$E2FSCK_PROG" e2fsck > # ext4 does not support zoned block device > _require_non_zoned_device "${SCRATCH_DEV}" > +_require_loop > > BLOCK_SIZE=`_get_block_size $TEST_DIR` > > diff --git a/tests/generic/648 b/tests/generic/648 > index e5c743c5..d7bf5697 100755 > --- a/tests/generic/648 > +++ b/tests/generic/648 > @@ -39,6 +39,7 @@ _require_scratch_reflink > _require_cp_reflink > _require_dm_target error > _require_command "$KILLALL_PROG" "killall" > +_require_loop > > echo "Silence is golden." > > -- > 2.26.3 >
diff --git a/tests/btrfs/012 b/tests/btrfs/012 index 29552b14..60461a34 100755 --- a/tests/btrfs/012 +++ b/tests/btrfs/012 @@ -30,6 +30,7 @@ _require_command "$MKFS_EXT4_PROG" mkfs.ext4 _require_command "$E2FSCK_PROG" e2fsck # ext4 does not support zoned block device _require_non_zoned_device "${SCRATCH_DEV}" +_require_loop BLOCK_SIZE=`_get_block_size $TEST_DIR` diff --git a/tests/generic/648 b/tests/generic/648 index e5c743c5..d7bf5697 100755 --- a/tests/generic/648 +++ b/tests/generic/648 @@ -39,6 +39,7 @@ _require_scratch_reflink _require_cp_reflink _require_dm_target error _require_command "$KILLALL_PROG" "killall" +_require_loop echo "Silence is golden."
Got a new box running overnight fstests and noticed a couple of failures because I forgot to enable loop device support. Fix these two tests to have _require_loop so they don't fail if there's no loop device support. Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- tests/btrfs/012 | 1 + tests/generic/648 | 1 + 2 files changed, 2 insertions(+)