From patchwork Fri Dec 4 15:41:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Moyer X-Patchwork-Id: 7769451 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id ABFF6BEEE1 for ; Fri, 4 Dec 2015 15:41:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BABAC205BA for ; Fri, 4 Dec 2015 15:41:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC7A7205C2 for ; Fri, 4 Dec 2015 15:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753453AbbLDPlu (ORCPT ); Fri, 4 Dec 2015 10:41:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42728 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753309AbbLDPlt (ORCPT ); Fri, 4 Dec 2015 10:41:49 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id D277EC04FF81 for ; Fri, 4 Dec 2015 15:41:49 +0000 (UTC) Received: from segfault.boston.devel.redhat.com (segfault.boston.devel.redhat.com [10.19.60.26]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB4FfmdZ007578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 4 Dec 2015 10:41:49 -0500 From: Jeff Moyer To: fstests@vger.kernel.org Subject: [patch] xfs/259 - inherit $_fs_has_crcs X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 04 Dec 2015 10:41:48 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, When running xfs/259 against a file system that has crcs disabled, the test will fail. The problem is that mkfs.xfs now defaults to enabling crcs. So, when the test checks the underlying file system and finds crcs are disabled, it tries to create a file system with a block size that is too small to support them. The solution is to explicitly specify the crc feature. Signed-off-by: Jeff Moyer --- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tests/xfs/259 b/tests/xfs/259 index 16c1935..e0022ce 100755 --- a/tests/xfs/259 +++ b/tests/xfs/259 @@ -72,7 +72,7 @@ for del in $sizes_to_check; do lofile=$(losetup -f) losetup $lofile "$testfile" "$MKFS_XFS_PROG" -l size=32m -b size=$blocksize $lofile \ - >/dev/null || echo "mkfs failed!" + -m crc=$_fs_has_crcs>/dev/null || echo "mkfs failed!" sync losetup -d $lofile done