From patchwork Tue Dec 1 17:36:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Moyer X-Patchwork-Id: 7739161 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 33EE19F39D for ; Tue, 1 Dec 2015 17:36:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 75CB9205E1 for ; Tue, 1 Dec 2015 17:36:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F61F20524 for ; Tue, 1 Dec 2015 17:36:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756556AbbLARgG (ORCPT ); Tue, 1 Dec 2015 12:36:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57378 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756532AbbLARgB (ORCPT ); Tue, 1 Dec 2015 12:36:01 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 73F61A81 for ; Tue, 1 Dec 2015 17:36:01 +0000 (UTC) Received: from segfault.boston.devel.redhat.com (segfault.boston.devel.redhat.com [10.19.60.26]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB1Ha0Zx027692 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Tue, 1 Dec 2015 12:36:01 -0500 From: Jeff Moyer To: fstests@vger.kernel.org Subject: [patch] make sure to _require_attrs when necessary X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 01 Dec 2015 12:36:00 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP xfs/073 and xfs/295 forgot to _require_attrs. Fix it. Signed-off-by: Jeff Moyer Reviewed-by: Eric Sandeen --- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tests/xfs/073 b/tests/xfs/073 index 32faffd..9def3c6 100755 --- a/tests/xfs/073 +++ b/tests/xfs/073 @@ -33,6 +33,7 @@ status=1 # failure is the default! # get standard environment, filters and checks . ./common/rc . ./common/filter +. ./common/attr # don't put fs images in /tmp imgs=$TEST_DIR/$$ @@ -127,6 +128,7 @@ _verify_copy() _supported_fs xfs _supported_os Linux _require_test +_require_attrs [ "$USE_EXTERNAL" = yes ] && _notrun "Cannot xfs_copy with external devices" [ -n "$XFS_COPY_PROG" ] || _notrun "xfs_copy binary not yet installed" diff --git a/tests/xfs/295 b/tests/xfs/295 index 79f27bd..2325537 100755 --- a/tests/xfs/295 +++ b/tests/xfs/295 @@ -39,6 +39,7 @@ _cleanup() # get standard environment, filters and checks . ./common/rc . ./common/filter +. ./common/attr # real QA test starts here @@ -46,6 +47,7 @@ _cleanup() _supported_fs xfs _supported_os IRIX Linux _require_scratch +_require_attrs rm -f $seqres.full