From patchwork Fri Nov 2 05:22:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff King X-Patchwork-Id: 10664941 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4A07713BF for ; Fri, 2 Nov 2018 05:23:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 460172BCB4 for ; Fri, 2 Nov 2018 05:23:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 341C52BC9B; Fri, 2 Nov 2018 05:23:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBBAE2BC9B for ; Fri, 2 Nov 2018 05:23:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727764AbeKBO2e (ORCPT ); Fri, 2 Nov 2018 10:28:34 -0400 Received: from cloud.peff.net ([104.130.231.41]:37636 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727350AbeKBO2e (ORCPT ); Fri, 2 Nov 2018 10:28:34 -0400 Received: (qmail 26564 invoked by uid 109); 2 Nov 2018 05:22:41 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 02 Nov 2018 05:22:41 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 623 invoked by uid 111); 2 Nov 2018 05:21:57 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Fri, 02 Nov 2018 01:21:57 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 02 Nov 2018 01:22:39 -0400 Date: Fri, 2 Nov 2018 01:22:39 -0400 From: Jeff King To: git@vger.kernel.org Subject: [PATCH 0/3] mixed bag of -Wunused-parameter bugfixes Message-ID: <20181102052239.GA19162@sigill.intra.peff.net> MIME-Version: 1.0 Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Here are three minor bug-fixes that can be applied independently. The common thread is that I found them by looking at the results of compiling with -Wunused-parameter. In each of these cases, the parameter _should_ be used, and not doing so was a bug. [1/3]: rev-list: handle flags for --indexed-objects [2/3]: approxidate: handle pending number for "specials" [3/3]: pathspec: handle non-terminated strings with :(attr) date.c | 60 ++++++++++++++++++++++------------------ dir.c | 7 +++++ revision.c | 15 ++++++---- t/t0006-date.sh | 1 + t/t6000-rev-list-misc.sh | 7 +++++ 5 files changed, 57 insertions(+), 33 deletions(-) -Peff