mbox series

[GSoC,RFC/PATCH,0/1]

Message ID 20190315150142.20672-1-jkapil.cs@gmail.com (mailing list archive)
Headers show
Series [GSoC,RFC/PATCH,1/1] userdiff - support shell script | expand

Message

Kapil Jain March 15, 2019, 3:01 p.m. UTC
From: Kapil <jkapil.cs@gmail.com>


Kapil (1):
  userdiff - support shell script

 t/t4018-diff-funcname.sh | 1 +
 t/t4034-diff-words.sh    | 1 +
 userdiff.c               | 5 +++++
 3 files changed, 7 insertions(+)

Comments

Thomas Gummerer March 15, 2019, 10:39 p.m. UTC | #1
On 03/15, jkapil.cs@gmail.com wrote:
> From: Kapil <jkapil.cs@gmail.com>
> 

The cover letter should give reviewers a short introduction what a
patch series is about.  It's often not worth including a cover letter
if there is only a single patch, or only a couple of patches.

It is okay to send a cover letter for a single patch, however it
should include some explanation for the patch series, and not just
duplicate what's said in the commit message of the actual patch.  An
empty cover letter as this one here is just noise, and should be
omitted.

> Kapil (1):
>   userdiff - support shell script
> 
>  t/t4018-diff-funcname.sh | 1 +
>  t/t4034-diff-words.sh    | 1 +
>  userdiff.c               | 5 +++++
>  3 files changed, 7 insertions(+)
> 
> -- 
> 2.14.2
>