[00/20] SHA-256 test fixes, part 7

Message

brian m. carlson Dec. 21, 2019, 7:49 p.m. UTC

This is the seventh in a series of test fixes to make our testsuite work
with SHA-256.  Included in this series are fixes to a variety of tests
from t4054 to t5604.

I don't expect any of these to be terribly controversial (or, honestly,
that exciting), but of course any feedback is welcome.

There will likely be two or three more series of test fix patches coming
down the line.  I'll try to be a bit better about getting them sent out
in a timely manner.

I fully realize that we're entering a time of the year when many people
will be off and with family and friends (and this is true for me as
well), so it's fine if folks don't get to this series right away.  As is
usual with these series, there will likely be a couple versions, so
there will be plenty of time to incorporate any feedback.  Please feel
free to respond when it's convenient for you.

brian m. carlson (20):
  t4054: make hash-size independent
  t4066: compute index line in diffs
  t4134: compute appropriate length constant
  t4200: make hash size independent
  t4202: abstract away SHA-1-specific constants
  t4204: make hash size independent
  t4300: abstract away SHA-1-specific constants
  t5318: update for SHA-256
  t5319: change invalid offset for SHA-256 compatibility
  t5319: make test work with SHA-256
  t5324: make hash size independent
  t5504: make hash algorithm independent
  t5510: make hash size independent
  t5512: abstract away SHA-1-specific constants
  t5530: compute results based on object length
  t5537: make hash size independent
  t5540: make hash size independent
  t5562: use $ZERO_OID
  t5601: switch into repository to hash object
  t5604: make hash independent

 t/t4054-diff-bogus-tree.sh             |   3 +-
 t/t4066-diff-emit-delay.sh             |  10 +-
 t/t4134-apply-submodule.sh             |   5 +-
 t/t4200-rerere.sh                      |   3 +-
 t/t4202-log.sh                         | 127 +++++++++--------
 t/t4204-patch-id.sh                    |   2 +-
 t/t4300-merge-tree.sh                  | 188 ++++++++++++-------------
 t/t5318-commit-graph.sh                |   2 +-
 t/t5319-multi-pack-index.sh            |  26 +++-
 t/t5324-split-commit-graph.sh          |  13 +-
 t/t5504-fetch-receive-strict.sh        |  17 +--
 t/t5510-fetch.sh                       |   9 +-
 t/t5512-ls-remote.sh                   |  17 +--
 t/t5530-upload-pack-error.sh           |  26 ++--
 t/t5537-fetch-shallow.sh               |   8 +-
 t/t5540-http-push-webdav.sh            |   6 +-
 t/t5562-http-backend-content-length.sh |   2 +-
 t/t5601-clone.sh                       |   4 +-
 t/t5604-clone-reference.sh             |   5 +-
 19 files changed, 254 insertions(+), 219 deletions(-)

Comments

Derrick Stolee Dec. 26, 2019, 2:51 p.m. UTC | #1

On 12/21/2019 2:49 PM, brian m. carlson wrote:
> This is the seventh in a series of test fixes to make our testsuite work
> with SHA-256.  Included in this series are fixes to a variety of tests
> from t4054 to t5604.

Thanks for doing the hard work needed for this important transition.

This series looks good to me. I commented only on the parts that I
knew a lot about just to say "I'm sorry this was complicated."

Thanks,
-Stolee