[v2,0/5] Wildcard matching for credentials

Message

brian m. carlson Feb. 20, 2020, 2:24 a.m. UTC

This series introduces wildcard matching (that is, urlmatch support) for
credential config options, just like for the http options.  This is
helpful in corporate environments where custom credentials should be
used across a wide variety of subdomains.

Changes from v1:
* Add a variety of additional tests in patch 3.
* Switch to using the last matching config option for
  credential.username like we do everywhere else.
* Use all matching config keys, as we did before.
* Skip calling git_default_config.
* Fix percent-encoding handling and add a function to handle that.

brian m. carlson (5):
  mailmap: add an additional email address for brian m. carlson
  t1300: add test for urlmatch with multiple wildcards
  t0300: add tests for some additional cases
  credential: use the last matching username in the config
  credential: allow wildcard patterns when matching config

 .mailmap                         |   1 +
 Documentation/gitcredentials.txt |   4 +-
 credential.c                     |  75 +++++++++++++-----
 credential.h                     |   3 +-
 strbuf.c                         |  15 ++++
 strbuf.h                         |   6 ++
 t/t0300-credentials.sh           | 128 +++++++++++++++++++++++++++++++
 t/t1300-config.sh                |   6 ++
 urlmatch.c                       |   4 +-
 urlmatch.h                       |   9 +++
 10 files changed, 228 insertions(+), 23 deletions(-)

Comments

Jeff King Feb. 21, 2020, 6:10 a.m. UTC | #1

On Thu, Feb 20, 2020 at 02:24:08AM +0000, brian m. carlson wrote:

> This series introduces wildcard matching (that is, urlmatch support) for
> credential config options, just like for the http options.  This is
> helpful in corporate environments where custom credentials should be
> used across a wide variety of subdomains.
> 
> Changes from v1:
> * Add a variety of additional tests in patch 3.
> * Switch to using the last matching config option for
>   credential.username like we do everywhere else.
> * Use all matching config keys, as we did before.
> * Skip calling git_default_config.
> * Fix percent-encoding handling and add a function to handle that.

Thanks, this addresses all of my concerns, and I'm really happy to see
all the new tests covering various bits from our discussion. Really
cleanly done.

-Peff