| Message ID | 20200730002735.87655-1-alipman88@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Introduce --first-parent flag for git bisect | expand |
Aaron Lipman <alipman88@gmail.com> writes: > Junio, thank you for the feedback and the explanation regarding > count_distance(). I've gone ahead and implemented all your suggestions. > >> In chronological order, please. > I submitted my initial patch through GitGitGadget. I don't see a way to > control the order GitGitGadget sends emails,... Ah, I was referring to the order of sign-off, helped-by, etc. Somebody writes a patch that is left on the list, you pick it up and polish it for perfection, and send the result to the list. So based-on would come first because it happened first, and then you worked further until the result deserves to be signed-off and finally you sent it out. So your sign-off comes the last.
Junio, thank you for the feedback and the explanation regarding count_distance(). I've gone ahead and implemented all your suggestions. > In chronological order, please. I submitted my initial patch through GitGitGadget. I don't see a way to control the order GitGitGadget sends emails, so I'm switching to git send-email for this iteration. Please continue to let me know if I'm missing a convention. Aaron Lipman (3): rev-list: allow bisect and first-parent flags bisect: introduce first-parent flag bisect: combine args passed to find_bisection() Documentation/git-bisect.txt | 13 +++++++- Documentation/rev-list-options.txt | 7 ++-- bisect.c | 51 ++++++++++++++++++++++-------- bisect.h | 7 +++- builtin/bisect--helper.c | 16 +++++++--- builtin/rev-list.c | 9 +++++- revision.c | 3 -- t/t6000-rev-list-misc.sh | 4 +-- t/t6002-rev-list-bisect.sh | 45 ++++++++++++++++++++++++++ t/t6030-bisect-porcelain.sh | 17 ++++++++++ 10 files changed, 142 insertions(+), 30 deletions(-)