| Message ID | 20200825113020.71801-1-shouryashukla.oo@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | submodule: fixup to summary-v3 | expand |
On 25-08-2020 17:00, Shourya Shukla wrote: > Greetings, > > The v3 of 'git submodule summary' port to C is currently in 'next' > branch of git/git. Recently, the patch recieved some comments from > Peff, Dscho and Kaartic: > > 1. The definition of 'print_submodule_summary()' contained two > unused parameters namely 'missing_src' and 'missing_dst'. Hence, > I had to eliminate them as covered in the commit a22ffa950f > a22ffa950f (submodule: eliminate unused parameters from > print_submodule_summary(), 2020-08-21). Reported by Peff. > Junio also advised to make the output in case of an unexpected > file mode a bit more user friendly by outputting an octal instead > of a decimal. > > 2. The function definitions of 'verify_submodule_committish()' and > 'print_submodule_summary()' had wrong styling in terms of the > asterisk placement. Hence it was fixed in 32934998ee (submodule: > fix style in function definition, 2020-08-22). Reported by > Kaartic. > > 2. The test script 't7421-submodule-summary-add.sh' failed in > Windows due to failure of t7421.4. Precisely, the 'test_i18ngrep' > check failed on Windows since the error message which was being > grepped was different on Windows; it was designed to work on > Linux. Therefore, we had to eliminate the grep check in t7421.4 > and replace it with a check to see if there is any error message > or not using 'test_must_be_empty'. Also, to support this change, > we had to make some small changes in 'print_submodule_summary()' > function. The call to verify_submodule_committish()' had to be > guarded using 'p->status !=D' so that it isn't called when the SM > directory does not exist, therefore, the error message is not > displayed. This resulted in 82e0956cd2 (t7421: eliminate 'grep' > check in t7421.4 for mingw compatibility, 2020-08-22). Reported > by Dscho. > While the cover letter is nice, it doesn't make much sense to refer to patches that are part of the series using the commit hashes of their "local" commits. It's more common to refer to them as using the position of the patch such as [1/3] etc.
Greetings, The v3 of 'git submodule summary' port to C is currently in 'next' branch of git/git. Recently, the patch recieved some comments from Peff, Dscho and Kaartic: 1. The definition of 'print_submodule_summary()' contained two unused parameters namely 'missing_src' and 'missing_dst'. Hence, I had to eliminate them as covered in the commit a22ffa950f a22ffa950f (submodule: eliminate unused parameters from print_submodule_summary(), 2020-08-21). Reported by Peff. Junio also advised to make the output in case of an unexpected file mode a bit more user friendly by outputting an octal instead of a decimal. 2. The function definitions of 'verify_submodule_committish()' and 'print_submodule_summary()' had wrong styling in terms of the asterisk placement. Hence it was fixed in 32934998ee (submodule: fix style in function definition, 2020-08-22). Reported by Kaartic. 2. The test script 't7421-submodule-summary-add.sh' failed in Windows due to failure of t7421.4. Precisely, the 'test_i18ngrep' check failed on Windows since the error message which was being grepped was different on Windows; it was designed to work on Linux. Therefore, we had to eliminate the grep check in t7421.4 and replace it with a check to see if there is any error message or not using 'test_must_be_empty'. Also, to support this change, we had to make some small changes in 'print_submodule_summary()' function. The call to verify_submodule_committish()' had to be guarded using 'p->status !=D' so that it isn't called when the SM directory does not exist, therefore, the error message is not displayed. This resulted in 82e0956cd2 (t7421: eliminate 'grep' check in t7421.4 for mingw compatibility, 2020-08-22). Reported by Dscho. summary-v3: https://lore.kernel.org/git/20200812194404.17028-1-shouryashukla.oo@gmail.com/ Peff's comment: https://lore.kernel.org/git/20200818020838.GA1872632@coredump.intra.peff.net/ Dscho' comment: https://lore.kernel.org/git/nycvar.QRO.7.76.6.2008211708280.56@tvgsbejvaqbjf.bet/ Kaartic's comment: https://lore.kernel.org/git/377b1a2ad60c5ca30864f48c5921ff89b5aca65b.camel@gmail.com/ Junio's comment regarding unexpected file mode: https://lore.kernel.org/git/xmqqo8n053r6.fsf@gitster.c.googlers.com/ Feedback and reviews are appreciated. Regards, Shourya Shukla Shourya Shukla (3): submodule: eliminate unused parameters from print_submodule_summary() submodule: fix style in function definition t7421: eliminate 'grep' check in t7421.4 for mingw compatibility builtin/submodule--helper.c | 17 ++++++++--------- t/t7421-submodule-summary-add.sh | 2 +- 2 files changed, 9 insertions(+), 10 deletions(-)