mbox series

[0/2] Fix a segfault in git log --notes

Message ID 20201123032342.24566-1-nate@roosteregg.cc (mailing list archive)
Headers show
Series Fix a segfault in git log --notes | expand

Message

nate@roosteregg.cc Nov. 23, 2020, 3:23 a.m. UTC 
From: Nate Avers <nate@roosteregg.cc>

Hi,

I came across a segfault in git log --notes (also affects diff-tree)
when notes.displayRef is configured with no value (not an empty value).
It appears to stem from a missing return statement in
notes.c:notes_display_config(). Very small fix. (Not sure how much sense
it makes to include the test.)

Thanks,
Nate

Nate Avers (2):
  notes.c: fix a segfault in notes_display_config()
  t3301: test proper exit response to no-value notes.displayRef.

 notes.c          | 2 +-
 t/t3301-notes.sh | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)