[v3,00/10] Modernizing the t7001 test script

Message

Shubham Verma Feb. 11, 2021, 7:46 p.m. UTC

In this patch series modernize the t7001 test script by changing the
style of its tests from an old one to the modern one and by cleaning
up the test script.

Changes since v2:

- Correct the author name spelling

Thanks everyone for your feedback and suggestions.

Shubham Verma (10):
  t7001: modernize test formatting
  t7001: indent with TABs instead of spaces
  t7001: remove unnecessary blank lines
  t7001: modernize subshell formatting
  t7001: remove whitespace after redirect operators
  t7001: avoid using `cd` outside of subshells
  t7001: use '>' rather than 'touch'
  t7001: put each command on a separate line
  t7001: use here-docs instead of echo
  t7001: use `test` rather than `[`

 t/t7001-mv.sh | 420 ++++++++++++++++++++++++--------------------------
 1 file changed, 199 insertions(+), 221 deletions(-)

Comments

Junio C Hamano Feb. 11, 2021, 9:44 p.m. UTC | #1

Shubham Verma <[e-mail]> writes:

> In this patch series modernize the t7001 test script by changing the
> style of its tests from an old one to the modern one and by cleaning
> up the test script.
>
> Changes since v2:
>
> - Correct the author name spelling
>
> Thanks everyone for your feedback and suggestions.

I've compared between v2 and v3 and verified the only change is the
name spelling, so I'll port over Eric's reviewed-by's from the
previous round.

Thanks.

Shubham Verma Feb. 23, 2021, 8:26 a.m. UTC | #2

Hello Junio,

I already corrected the author-name spelling in this v3 series
but I looking at the last "What's Cooking" message and saw that
Modernizing the t7001 test script series described as
"Expecting the final version with corrected author attribution".
Please once look at my patch series.

Thank You!


On Fri, Feb 12, 2021 at 3:14 AM Junio C Hamano <[e-mail]> wrote:
>
> Shubham Verma <[e-mail]> writes:
>
> > In this patch series modernize the t7001 test script by changing the
> > style of its tests from an old one to the modern one and by cleaning
> > up the test script.
> >
> > Changes since v2:
> >
> > - Correct the author name spelling
> >
> > Thanks everyone for your feedback and suggestions.
>
> I've compared between v2 and v3 and verified the only change is the
> name spelling, so I'll port over Eric's reviewed-by's from the
> previous round.
>
> Thanks.
>
>
>

Junio C Hamano Feb. 23, 2021, 5:33 p.m. UTC | #3

Shubham Verma <[e-mail]> writes:

> Hello Junio,
>
> I already corrected the author-name spelling in this v3 series
> but I looking at the last "What's Cooking" message and saw that
> Modernizing the t7001 test script series described as
> "Expecting the final version with corrected author attribution".

I looked at it on Feb 12 and requeued already, but the entry in the
what's cooking report was left stale by mistake.

Thanks for pinging.