Message ID | 20210807071613.99610-1-raykar.ath@gmail.com (mailing list archive) |
---|---|
Headers | show |
Series | submodule: convert the rest of 'add' to C | expand |
On 07/08/21 12:46 pm, Atharva Raykar wrote: > Changes since v3: > > * Rename the libified dir helper and update the docstring. > Just a note. I'm not really sure about this yet, the fact that this series depends on the change introduced by 'ar/submodule-add-config'[1] might be worth mentioning in re-rolls too. This could help the maintainer to easily identify the topic dependency :-) [1]: https://lore.kernel.org/git/20210801063352.50813-1-raykar.ath@gmail.com/ And ... > Atharva Raykar (8): > submodule--helper: add options for compute_submodule_clone_url() > submodule--helper: refactor resolve_relative_url() helper > submodule--helper: remove repeated code in sync_submodule() > dir: libify and export helper functions from clone.c > submodule--helper: convert the bulk of cmd_add() to C > submodule--helper: remove add-clone subcommand > submodule--helper: remove add-config subcommand > submodule--helper: remove resolve-relative-url subcommand > > builtin/clone.c | 118 +------------- > builtin/submodule--helper.c | 307 +++++++++++++++++++----------------- > dir.c | 114 +++++++++++++ > dir.h | 10 ++ > git-submodule.sh | 96 +---------- > 5 files changed, 290 insertions(+), 355 deletions(-) > > Range-diff against v3: Thanks for consistently including a useful range-diff!