mbox series

[0/2] worktree: fix incorrectly-ordered messages on Windows

Message ID 20211203034420.47447-1-sunshine@sunshineco.com (mailing list archive)
Headers show
Series worktree: fix incorrectly-ordered messages on Windows | expand

Message

Eric Sunshine Dec. 3, 2021, 3:44 a.m. UTC
This patch series fixes a problem in which a chatty "Preparing worktree"
message and a subsequent fatal error message appear in the wrong order
on Microsoft Windows, which may confuse readers into thinking that the
operation somehow succeeded despite the error.

Unlike the original RFC attempt[*] to fix this problem at a low level in
a generalized fashion, patch [1/2] localizes the fix to git-worktree
itself by making it conform to common Git practice of issuing chatty
messages to stderr rather than to stdout as is currently the case.

Patch [2/2] is just a drive-by fix for a minor documentation problem I
noticed along the way.

[*]: https://lore.kernel.org/git/20211130043946.19987-1-sunshine@sunshineco.com/

Eric Sunshine (2):
  worktree: send "chatty" messages to stderr
  git-worktree.txt: add missing `-v` to synopsis for `worktree list`

 Documentation/git-worktree.txt |  2 +-
 builtin/worktree.c             | 14 +++++++-------
 t/t2401-worktree-prune.sh      | 14 +++++++-------
 t/t2402-worktree-list.sh       |  2 +-
 t/t2406-worktree-repair.sh     | 30 ++++++++++++------------------
 5 files changed, 28 insertions(+), 34 deletions(-)