mbox series

[v3,RESEND,0/2] git-p4: remove "debug" and "rollback" verbs

Message ID 20220104123431.1710-1-jholdsworth@nvidia.com (mailing list archive)
Headers show
Series git-p4: remove "debug" and "rollback" verbs | expand

Message

Joel Holdsworth Jan. 4, 2022, 12:34 p.m. UTC 
git-p4 contains a selection of verbs for various functions of the
script. The "debug" and "rollback" verbs appear to have been added early
in the development life of git-p4. They were once used as debugging
tools, but are no longer being used either by developers or users, and
are largely undocumented. Removing these verbs simplifies the script by
removing dead code, and increases usability by reducing complexity.

This third version of the patch-set adds more detail to the commit
messages.

Joel Holdsworth (2):
  git-p4: remove "debug" verb
  git-p4: remove "rollback" verb

 git-p4.py | 76 -------------------------------------------------------
 1 file changed, 76 deletions(-)

Comments

Andrew Oakley Jan. 4, 2022, 9:54 p.m. UTC | #1 
On Tue,  4 Jan 2022 12:34:29 +0000
Joel Holdsworth <jholdsworth@nvidia.com> wrote:

> git-p4 contains a selection of verbs for various functions of the
> script. The "debug" and "rollback" verbs appear to have been added
> early in the development life of git-p4. They were once used as
> debugging tools, but are no longer being used either by developers or
> users, and are largely undocumented. Removing these verbs simplifies
> the script by removing dead code, and increases usability by reducing
> complexity.

I agree, these commands look rather usesless and I've never used them.

The patches to remove them look correct to me.

Thanks