| Message ID | 20230110005251.10539-1-nsengiyumvawilberforce@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ref-filter: add new "signature" atom | expand |
On Tue, Jan 10, 2023 at 1:53 AM Nsengiyumva Wilberforce <nsengiyumvawilberforce@gmail.com> wrote: > Documentation/git-for-each-ref.txt | 27 +++++++ > ref-filter.c | 101 +++++++++++++++++++++++++ > t/t6300-for-each-ref.sh | 116 +++++++++++++++++++++++++++++ > 3 files changed, 244 insertions(+) > > Range-diff against v2: > 1: ce51d8e79e = 1: ce51d8e79e ref-filter: add new "signature" atom It's strange that it's saying nothing changed compared to v2. I guess the v2 it's talking about is not actually the v2 you sent to the list, right? Anyway it's better if you can describe a bit with your own words in the cover letter what changed, and sometimes even what didn't change, since the previous version you sent. For example, here you can say that you decided to actually remove the test that checked the %(signature) format and explain a bit the reason why you did that. You can also send links in the cover letter to the branch(es) (on GitHub, GitLab or other such platforms) that you used for this and previous versions of the patch (or patch series). It can help people try it and look at the changes on their own system. Thanks.
This commit duplicates the code for `signature` atom from pretty.c to ref-filter.c. This feature will help to get rid of current duplicate implementation of `signature` atom when unifying implementations by using ref-filter logic everywhere when ref-filter can do everything pretty is doing. Add "signature" atom with `grade`, `signer`, `key`, `fingerprint`, `primarykeyfingerprint`, `trustlevel` as arguments. This code and its documentation are inspired by how the %GG, %G?, %GS, %GK, %GF, %GP, and %GT pretty formats were implemented. Co-authored-by: Hariom Verma <hariom18599@gmail.com> Co-authored-by: Jaydeep Das <jaydeepjd.8914@gmail.com> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Mentored-by: Hariom Verma <hariom18599@gmail.com> Signed-off-by: Nsengiyumva Wilberforce <nsengiyumvawilberforce@gmail.com> Nsengiyumva Wilberforce (1): ref-filter: add new "signature" atom Documentation/git-for-each-ref.txt | 27 +++++++ ref-filter.c | 101 +++++++++++++++++++++++++ t/t6300-for-each-ref.sh | 116 +++++++++++++++++++++++++++++ 3 files changed, 244 insertions(+) Range-diff against v2: 1: ce51d8e79e = 1: ce51d8e79e ref-filter: add new "signature" atom