[0/6] minor cleanups to fast-export --anonymize

Message

Jeff King March 22, 2023, 5:36 p.m. UTC

My goal here was cleaning up some -Wunused-parameter warnings, but doing
so required a few preparatory cleanups, one of which actually fixes a
really minor bug (in patch 4).

  [1/6]: fast-export: drop const when storing anonymized values
  [2/6]: fast-export: simplify initialization of anonymized hashmaps
  [3/6]: fast-export: factor out anonymized_entry creation
  [4/6]: fast-export: de-obfuscate --anonymize-map handling
  [5/6]: fast-export: drop data parameter from anonymous generators
  [6/6]: fast-export: drop unused parameter from anonymize_commit_message()

 builtin/fast-export.c            | 81 ++++++++++++++++++--------------
 t/t9351-fast-export-anonymize.sh |  2 +
 2 files changed, 47 insertions(+), 36 deletions(-)

-Peff

Comments

Derrick Stolee March 24, 2023, 5:40 p.m. UTC | #1

On 3/22/2023 1:36 PM, Jeff King wrote:
> My goal here was cleaning up some -Wunused-parameter warnings, but doing
> so required a few preparatory cleanups, one of which actually fixes a
> really minor bug (in patch 4).

I saw this was on its way to next(?) without any comment, but it
really doesn't need any. Each patch was clear and created a self-
sufficient reason, but the culmination of dropping parameters and
clearing up memory is also good.

Thanks,
-Stolee

Junio C Hamano March 24, 2023, 7:46 p.m. UTC | #2

Derrick Stolee <[e-mail]> writes:

> I saw this was on its way to next(?) without any comment, but it
> really doesn't need any. Each patch was clear and created a self-
> sufficient reason, but the culmination of dropping parameters and
> clearing up memory is also good.

I also thought these were self evidently ready for 'next'.  Thanks
for a positive confirmation.