[0/3] imap-send: some -Wunused-parameter cleanups

Message

Jeff King July 3, 2023, 6:32 a.m. UTC

Here are a few patches where I opted to clean up code rather than
marking parameters with UNUSED. Plus a bonus cleanup in patch 3 (though
I am also OK to drop that one; I don't care much about the imap-send
code, and I'd be just as happy if we deprecated and eventually dropped
the tool).

  [1/3]: imap-send: use server conf argument in setup_curl()
  [2/3]: imap-send: drop unused parameter from imap_cmd_cb callback
  [3/3]: imap-send: drop unused fields from imap_cmd_cb

 imap-send.c | 34 +++++++++++++++-------------------
 1 file changed, 15 insertions(+), 19 deletions(-)

-Peff

Comments

Junio C Hamano July 5, 2023, 5:18 p.m. UTC | #1

Jeff King <[e-mail]> writes:

> Here are a few patches where I opted to clean up code rather than
> marking parameters with UNUSED. Plus a bonus cleanup in patch 3 (though
> I am also OK to drop that one;

> I don't care much about the imap-send
> code, and I'd be just as happy if we deprecated and eventually dropped
> the tool).

Thanks---I too was wondering when we can drop 'imap-send' ;-)

>   [1/3]: imap-send: use server conf argument in setup_curl()
>   [2/3]: imap-send: drop unused parameter from imap_cmd_cb callback
>   [3/3]: imap-send: drop unused fields from imap_cmd_cb
>
>  imap-send.c | 34 +++++++++++++++-------------------
>  1 file changed, 15 insertions(+), 19 deletions(-)
>
> -Peff