[0/3] t/lib-rebase: (mostly) cosmetic improvements to set_fake_editor()

Message

Oswald Buddenhagen Aug. 7, 2023, 5:09 p.m. UTC

An update to the documentation, and two minor functional changes that don't
actually change anything given current use cases, and are therefore basically
documentation updates as well.

Oswald Buddenhagen (3):
  t/lib-rebase: set_fake_editor(): fix recognition of reset's short
    command
  t/lib-rebase: set_fake_editor(): handle FAKE_LINES more consistently
  t/lib-rebase: improve documentation of set_fake_editor()

 t/lib-rebase.sh | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

Comments

Phillip Wood Aug. 9, 2023, 1:05 p.m. UTC | #1

On 07/08/2023 18:09, Oswald Buddenhagen wrote:
> An update to the documentation, and two minor functional changes that don't
> actually change anything given current use cases, and are therefore basically
> documentation updates as well.

Thanks for re-rolling. I've left a couple of comments on the third 
patch, I don't have anything to add to Junio's comments on the first two.

Best Wishes

Phillip

> Oswald Buddenhagen (3):
>    t/lib-rebase: set_fake_editor(): fix recognition of reset's short
>      command
>    t/lib-rebase: set_fake_editor(): handle FAKE_LINES more consistently
>    t/lib-rebase: improve documentation of set_fake_editor()
> 
>   t/lib-rebase.sh | 25 ++++++++++++++-----------
>   1 file changed, 14 insertions(+), 11 deletions(-)
>