| Message ID | 20230925152517.803579-1-christian.couder@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Repack objects into separate packfiles based on a filter | expand |
Christian Couder <christian.couder@gmail.com> writes: > # Changes since version 6 > > Thanks to Junio who reviewed or commented on versions 1, 2, 3, 4 and > 5, and to Taylor who reviewed or commented on version 1, 3, 4, 5 and > 6! Thanks also to Robert Coup who participated in the discussions > related to version 2 and Peff who participated in the discussions > related to version 4. There are only the following changes since > version 6: > > - This series has been rebased on top of bcb6cae296 (The twelfth > batch, 2023-09-22) to fix conflicts with a `builtin/repack.c` > refactoring patch series called tb/repack-existing-packs-cleanup by > Taylor Blau that recently graduated to 'master': > > https://lore.kernel.org/git/cover.1694632644.git.me@ttaylorr.com/ > https://lore.kernel.org/git/xmqqil81wqkx.fsf@gitster.g/ > > - Patch 6/9 (repack: add `--filter=<filter-spec>` option) has been > reworked to apply on top of the above mentioned patch series. > Taylor even posted the fixup patch to apply to this series so that > it works well on top of his series: > > https://lore.kernel.org/git/ZQNKkn0YYLUyN5Ih@nand.local/ Thanks, both, for working well together. Will replace and merge to 'seen'. Let's see others supporting the change to chime in, and get it merged to 'next' soonish. I gave a quick cursory look and changes to rebuild on the "existing packs cleanup" topic all looked sensible.
On Mon, Sep 25, 2023 at 12:14:00PM -0700, Junio C Hamano wrote: > Thanks, both, for working well together. Christian made it easy to do so! ;-) > Will replace and merge to 'seen'. Let's see others supporting the > change to chime in, and get it merged to 'next' soonish. I gave a > quick cursory look and changes to rebuild on the "existing packs > cleanup" topic all looked sensible. Sounds good. I took a look over the range-diff and the changes were as expected. Having reviewed earlier rounds of this series in depth, I'm comfortable merging this down whenever you are. Thanks, Taylor
# Intro Last year, John Cai sent 2 versions of a patch series to implement `git repack --filter=<filter-spec>` and later I sent 4 versions of a patch series trying to do it a bit differently: - https://lore.kernel.org/git/pull.1206.git.git.1643248180.gitgitgadget@gmail.com/ - https://lore.kernel.org/git/20221012135114.294680-1-christian.couder@gmail.com/ In these patch series, the `--filter=<filter-spec>` removed the filtered out objects altogether which was considered very dangerous even though we implemented different safety checks in some of the latter series. In some discussions, it was mentioned that such a feature, or a similar feature in `git gc`, or in a new standalone command (perhaps called `git prune-filtered`), should put the filtered out objects into a new packfile instead of deleting them. Recently there were internal discussions at GitLab about either moving blobs from inactive repos onto cheaper storage, or moving large blobs onto cheaper storage. This lead us to rethink at repacking using a filter, but moving the filtered out objects into a separate packfile instead of deleting them. So here is a new patch series doing that while implementing the `--filter=<filter-spec>` option in `git repack`. # Use cases for the new feature This could be useful for example for the following purposes: 1) As a way for servers to save storage costs by for example moving large blobs, or all the blobs, or all the blobs in inactive repos, to separate storage (while still making them accessible using for example the alternates mechanism). 2) As a way to use partial clone on a Git server to offload large blobs to, for example, an http server, while using multiple promisor remotes (to be able to access everything) on the client side. (In this case the packfile that contains the filtered out object can be manualy removed after checking that all the objects it contains are available through the promisor remote.) 3) As a way for clients to reclaim some space when they cloned with a filter to save disk space but then fetched a lot of unwanted objects (for example when checking out old branches) and now want to remove these unwanted objects. (In this case they can first move the packfile that contains filtered out objects to a separate directory or storage, then check that everything works well, and then manually remove the packfile after some time.) As the features and the code are quite different from those in the previous series, I decided to start a new series instead of continuing a previous one. Also since version 2 of this new series, commit messages, don't mention uses cases like 2) or 3) above, as people have different opinions on how it should be done. How it should be done could depend a lot on the way promisor remotes are used, the software and hardware setups used, etc, so it seems more difficult to "sell" this series by talking about such use cases. As use case 1) seems simpler and more appealing, it makes more sense to only talk about it in the commit messages. # Changes since version 6 Thanks to Junio who reviewed or commented on versions 1, 2, 3, 4 and 5, and to Taylor who reviewed or commented on version 1, 3, 4, 5 and 6! Thanks also to Robert Coup who participated in the discussions related to version 2 and Peff who participated in the discussions related to version 4. There are only the following changes since version 6: - This series has been rebased on top of bcb6cae296 (The twelfth batch, 2023-09-22) to fix conflicts with a `builtin/repack.c` refactoring patch series called tb/repack-existing-packs-cleanup by Taylor Blau that recently graduated to 'master': https://lore.kernel.org/git/cover.1694632644.git.me@ttaylorr.com/ https://lore.kernel.org/git/xmqqil81wqkx.fsf@gitster.g/ - Patch 6/9 (repack: add `--filter=<filter-spec>` option) has been reworked to apply on top of the above mentioned patch series. Taylor even posted the fixup patch to apply to this series so that it works well on top of his series: https://lore.kernel.org/git/ZQNKkn0YYLUyN5Ih@nand.local/ I checked that CI tests passes in: https://github.com/chriscool/git/actions/runs/6300816764 All jobs seem to have succeeded. # Commit overview (No changes in any of the patches compared to version 5, except on patch 6/9.) * 1/9 pack-objects: allow `--filter` without `--stdout` To be able to later repack with a filter we need `git pack-objects` to write packfiles when it's filtering instead of just writing the pack without the filtered out objects to stdout. * 2/9 t/helper: add 'find-pack' test-tool For testing `git repack --filter=...` that we are going to implement, it's useful to have a test helper that can tell which packfiles contain a specific object. * 3/9 repack: refactor finishing pack-objects command This is a small refactoring creating a new useful function, so that `git repack --filter=...` will be able to reuse it. * 4/9 repack: refactor finding pack prefix This is another small refactoring creating a small function that will be reused in the next patch. * 5/9 pack-bitmap-write: rebuild using new bitmap when remapping This patch is new in version 6. It fixes an issue when bitmaps are rebuilt that was revealed by this series, and caused a CI test to fail. * 6/9 repack: add `--filter=<filter-spec>` option This actually adds the `--filter=<filter-spec>` option. It uses one `git pack-objects` process with the `--filter` option. And then another `git pack-objects` process with the `--stdin-packs` option. This is the only patch changed in version 7. * 7/9 gc: add `gc.repackFilter` config option This is a gc config option so that `git gc` can also repack using a filter and put the filtered out objects into a separate packfile. * 8/9 repack: implement `--filter-to` for storing filtered out objects For some use cases, it's interesting to create the packfile that contains the filtered out objects into a separate location. This is similar to the `--expire-to` option for cruft packfiles. * 9/9 gc: add `gc.repackFilterTo` config option This allows specifying the location of the packfile that contains the filtered out objects when using `gc.repackFilter`. # Range-diff since v6 1: da931b5082 = 1: eec0c09731 pack-objects: allow `--filter` without `--stdout` 2: 10504b3699 = 2: 19c8b8a4b9 t/helper: add 'find-pack' test-tool 3: ee12eb8ad7 ! 3: aaaf40bd5d repack: refactor finishing pack-objects command @@ builtin/repack.c: static void remove_redundant_bitmaps(struct string_list *inclu const char *destination, const char *pack_prefix, @@ builtin/repack.c: static int write_cruft_pack(const struct pack_objects_args *args, - struct string_list *existing_kept_packs) + struct existing_packs *existing) { struct child_process cmd = CHILD_PROCESS_INIT; - struct strbuf line = STRBUF_INIT; @@ builtin/repack.c: static int write_cruft_pack(const struct pack_objects_args *ar int cmd_repack(int argc, const char **argv, const char *prefix) @@ builtin/repack.c: int cmd_repack(int argc, const char **argv, const char *prefix) - struct string_list existing_nonkept_packs = STRING_LIST_INIT_DUP; - struct string_list existing_kept_packs = STRING_LIST_INIT_DUP; + struct string_list names = STRING_LIST_INIT_DUP; + struct existing_packs existing = EXISTING_PACKS_INIT; struct pack_geometry geometry = { 0 }; - struct strbuf line = STRBUF_INIT; struct tempfile *refs_snapshot = NULL; 4: d197e0c370 = 4: 1eb6bc3f7e repack: refactor finding pack prefix 5: abeef5fbad = 5: b9159e1803 pack-bitmap-write: rebuild using new bitmap when remapping 6: 31ca2579d3 ! 6: f2f5bb54d3 repack: add `--filter=<filter-spec>` option @@ Commit message As the interactions with kept packs are a bit tricky, a few related tests are added. + Helped-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: John Cai <johncai86@gmail.com> Signed-off-by: Christian Couder <chriscool@tuxfamily.org> @@ builtin/repack.c: static int finish_pack_objects_cmd(struct child_process *cmd, +static int write_filtered_pack(const struct pack_objects_args *args, + const char *destination, + const char *pack_prefix, -+ struct string_list *keep_pack_list, -+ struct string_list *names, -+ struct string_list *existing_packs, -+ struct string_list *existing_kept_packs) ++ struct existing_packs *existing, ++ struct string_list *names) +{ + struct child_process cmd = CHILD_PROCESS_INIT; + struct string_list_item *item; + FILE *in; -+ int ret, i; ++ int ret; + const char *caret; + const char *scratch; + int local = skip_prefix(destination, packdir, &scratch); @@ builtin/repack.c: static int finish_pack_objects_cmd(struct child_process *cmd, + + if (!pack_kept_objects) + strvec_push(&cmd.args, "--honor-pack-keep"); -+ for (i = 0; i < keep_pack_list->nr; i++) -+ strvec_pushf(&cmd.args, "--keep-pack=%s", -+ keep_pack_list->items[i].string); ++ for_each_string_list_item(item, &existing->kept_packs) ++ strvec_pushf(&cmd.args, "--keep-pack=%s", item->string); + + cmd.in = -1; + @@ builtin/repack.c: static int finish_pack_objects_cmd(struct child_process *cmd, + in = xfdopen(cmd.in, "w"); + for_each_string_list_item(item, names) + fprintf(in, "^%s-%s.pack\n", pack_prefix, item->string); -+ for_each_string_list_item(item, existing_packs) ++ for_each_string_list_item(item, &existing->non_kept_packs) ++ fprintf(in, "%s.pack\n", item->string); ++ for_each_string_list_item(item, &existing->cruft_packs) + fprintf(in, "%s.pack\n", item->string); + caret = pack_kept_objects ? "" : "^"; -+ for_each_string_list_item(item, existing_kept_packs) ++ for_each_string_list_item(item, &existing->kept_packs) + fprintf(in, "%s%s.pack\n", caret, item->string); + fclose(in); + @@ builtin/repack.c: int cmd_repack(int argc, const char **argv, const char *prefix + ret = write_filtered_pack(&po_args, + packtmp, + find_pack_prefix(packdir, packtmp), -+ &keep_pack_list, -+ &names, -+ &existing_nonkept_packs, -+ &existing_kept_packs); ++ &existing, ++ &names); + if (ret) + goto cleanup; + } @@ builtin/repack.c: int cmd_repack(int argc, const char **argv, const char *prefix close_object_store(the_repository->objects); @@ builtin/repack.c: int cmd_repack(int argc, const char **argv, const char *prefix) - string_list_clear(&existing_nonkept_packs, 0); - string_list_clear(&existing_kept_packs, 0); + string_list_clear(&names, 1); + existing_packs_release(&existing); free_pack_geometry(&geometry); + list_objects_filter_release(&po_args.filter_options); 7: fa70ae85f2 = 7: 7ea0307628 gc: add `gc.repackFilter` config option 8: e01ea3dd70 ! 8: 698647815b repack: implement `--filter-to` for storing filtered out objects @@ builtin/repack.c: int cmd_repack(int argc, const char **argv, const char *prefix - packtmp, + filter_to, find_pack_prefix(packdir, packtmp), - &keep_pack_list, - &names, + &existing, + &names); ## t/t7700-repack.sh ## @@ t/t7700-repack.sh: test_expect_success '--filter works with --pack-kept-objects and .keep packs' ' 9: d6ff314189 = 9: 57b2ba444c gc: add `gc.repackFilterTo` config option Christian Couder (9): pack-objects: allow `--filter` without `--stdout` t/helper: add 'find-pack' test-tool repack: refactor finishing pack-objects command repack: refactor finding pack prefix pack-bitmap-write: rebuild using new bitmap when remapping repack: add `--filter=<filter-spec>` option gc: add `gc.repackFilter` config option repack: implement `--filter-to` for storing filtered out objects gc: add `gc.repackFilterTo` config option Documentation/config/gc.txt | 16 ++ Documentation/git-pack-objects.txt | 4 +- Documentation/git-repack.txt | 23 +++ Makefile | 1 + builtin/gc.c | 10 ++ builtin/pack-objects.c | 8 +- builtin/repack.c | 164 ++++++++++++++------ pack-bitmap-write.c | 6 +- t/helper/test-find-pack.c | 50 +++++++ t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0080-find-pack.sh | 82 ++++++++++ t/t5317-pack-objects-filter-objects.sh | 8 + t/t6500-gc.sh | 24 +++ t/t7700-repack.sh | 197 +++++++++++++++++++++++++ 15 files changed, 544 insertions(+), 51 deletions(-) create mode 100644 t/helper/test-find-pack.c create mode 100755 t/t0080-find-pack.sh