[GSoC,0/1] add zero count optimization in ewah_bitmap.c

Message

Aryan Gupta March 10, 2024, 4:26 p.m. UTC

Hey everyone

I hope you are doing great. I came across a "todo" in the code base 
which was based on zero count optimization. I tried to fix do it but
I am not sure if this was the required this or not. I would love your 
guidance on this. 

Thank you. Have a nice day!

Regards
Aryan Gupta


Aryan Gupta (1):
  add zero count optimization in ewah_bitmap.c

 ewah/ewah_bitmap.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Junio C Hamano March 11, 2024, 4:08 p.m. UTC | #1

Aryan Gupta <[e-mail]> writes:

> Hey everyone
>
> I hope you are doing great. I came across a "todo" in the code base 
> which was based on zero count optimization. I tried to fix do it but
> I am not sure if this was the required this or not.

Do you mean that you are not sure if the improvement you made is
what Vicent Marti meant by "zero count optimization" when e1273106
(ewah: compressed bitmap implementation, 2013-11-14) was written?

Unfortunatelly, "what is "zero count optimization" in computer
programming?" does not produce great hits, and you are probably
better off to ask who wrote that comment (Cc'ed).

A few general pieces of advice:

 * We usually don't do a cover letter for a single patch (instead we
   write extra explanation after the three-dash line).

 * An optimization patch usually is expected to come with
   performance measurement, just like a bugfix patch is expected to
   come with tests that show existing breakages that change the
   behaviour for the better with the fix.

 * Pay attention to coding style, as deviating from existing style
   distracts reviewers and causes them to miss obvious bugs.

Thanks.

Aryan Gupta March 11, 2024, 10:29 p.m. UTC | #2

On Mon, Mar 11, 2024 at 5:08 PM Junio C Hamano <[e-mail]> wrote:
>
> Aryan Gupta <[e-mail]> writes:
>
> > Hey everyone
> >
> > I hope you are doing great. I came across a "todo" in the code base
> > which was based on zero count optimization. I tried to fix do it but
> > I am not sure if this was the required this or not.
>
> Do you mean that you are not sure if the improvement you made is
> what Vicent Marti meant by "zero count optimization" when e1273106
> (ewah: compressed bitmap implementation, 2013-11-14) was written?
>
Yes.
> Unfortunatelly, "what is "zero count optimization" in computer
> programming?" does not produce great hits, and you are probably
> better off to ask who wrote that comment (Cc'ed).
>
Sure.
> A few general pieces of advice:
>
>  * We usually don't do a cover letter for a single patch (instead we
>    write extra explanation after the three-dash line).
>
>  * An optimization patch usually is expected to come with
>    performance measurement, just like a bugfix patch is expected to
>    come with tests that show existing breakages that change the
>    behaviour for the better with the fix.
>
>  * Pay attention to coding style, as deviating from existing style
>    distracts reviewers and causes them to miss obvious bugs.
>
> Thanks.

Okay will take care of this. Thanks a lot.