[v4,0/2] Darcy's "date underflow fix" topic, final reroll

Message

Junio C Hamano June 25, 2024, 11:12 p.m. UTC

So it has been some time since we discussed this topic.  Let's clean
up the messy "SQUASH???" patches I had to queue on top of the main
patch to keep the CI working and make them into a preliminary patch.

The tree at the end of the series is identical to what has been
queued in 'seen' for the past few weeks.  The only difference is
that we first lay groundwork to skip certain time-parsing tests on
32-bit systems first, and then use Darcy's patch with minimum
adjustments for 32-bit systems.


Darcy Burke (1):
  date: detect underflow/overflow when parsing dates with timezone offset

Junio C Hamano (1):
  t0006: simplify prerequisites

 date.c          | 12 +++++++++++-
 t/t0006-date.sh | 51 +++++++++++++++++++++++++++++++++++++++++++------
 2 files changed, 56 insertions(+), 7 deletions(-)

Comments

Phillip Wood June 26, 2024, 3:21 p.m. UTC | #1

Hi Junio

On 26/06/2024 00:12, Junio C Hamano wrote:
> So it has been some time since we discussed this topic.  Let's clean
> up the messy "SQUASH???" patches I had to queue on top of the main
> patch to keep the CI working and make them into a preliminary patch.
> 
> The tree at the end of the series is identical to what has been
> queued in 'seen' for the past few weeks.  The only difference is
> that we first lay groundwork to skip certain time-parsing tests on
> 32-bit systems first, and then use Darcy's patch with minimum
> adjustments for 32-bit systems.

I've had a read through this verison and I don't have anything to add to 
Eric's comments.

Best Wishes

Phillip


> Darcy Burke (1):
>    date: detect underflow/overflow when parsing dates with timezone offset
> 
> Junio C Hamano (1):
>    t0006: simplify prerequisites
> 
>   date.c          | 12 +++++++++++-
>   t/t0006-date.sh | 51 +++++++++++++++++++++++++++++++++++++++++++------
>   2 files changed, 56 insertions(+), 7 deletions(-)
>

Junio C Hamano June 26, 2024, 6:32 p.m. UTC | #2

Phillip Wood <[e-mail]> writes:

> Hi Junio
>
> On 26/06/2024 00:12, Junio C Hamano wrote:
>> So it has been some time since we discussed this topic.  Let's clean
>> up the messy "SQUASH???" patches I had to queue on top of the main
>> patch to keep the CI working and make them into a preliminary patch.
>> The tree at the end of the series is identical to what has been
>> queued in 'seen' for the past few weeks.  The only difference is
>> that we first lay groundwork to skip certain time-parsing tests on
>> 32-bit systems first, and then use Darcy's patch with minimum
>> adjustments for 32-bit systems.
>
> I've had a read through this verison and I don't have anything to add
> to Eric's comments.
>
> Best Wishes

Thanks, let's mark it for 'next' then.