mbox series

[0/6] unused parameters: the final countdown

Message ID 20240828035722.GA3998881@coredump.intra.peff.net (mailing list archive)
Headers show
Series unused parameters: the final countdown | expand

Message

Jeff King Aug. 28, 2024, 3:57 a.m. UTC 
After many long sets of patches fixing and annotating existing cases,
this is the culminating series that actually turns on -Wunused-parameter
in our DEVELOPER=1 builds.

When applied on 'master', everything should compile cleanly with the new
warning. There are some new cases introduced in 'next', but I'll send
separate patches to go on those individual topics.

The first two patches fix new spots that cropped up since the last round
of fixes. Patches 3-5 address compat/ code. And then the interesting one
is patch 6.

  [1/6]: gc: mark unused config parameter in virtual functions
  [2/6]: t-reftable-readwrite: mark unused parameter in callback function
  [3/6]: compat: disable -Wunused-parameter in 3rd-party code
  [4/6]: compat: disable -Wunused-parameter in win32/headless.c
  [5/6]: compat: mark unused parameters in win32/mingw functions
  [6/6]: config.mak.dev: enable -Wunused-parameter by default

 builtin/gc.c                        | 16 ++++++++--------
 compat/mingw.c                      | 15 ++++++++-------
 compat/mingw.h                      | 18 +++++++++---------
 compat/nedmalloc/nedmalloc.c        |  2 ++
 compat/regex/regcomp.c              |  2 ++
 compat/stub/procinfo.c              |  2 +-
 compat/win32/headless.c             |  2 ++
 compat/win32/pthread.c              |  2 +-
 compat/win32/pthread.h              |  4 ++--
 compat/win32/syslog.c               |  2 +-
 compat/win32mmap.c                  |  2 +-
 compat/winansi.c                    |  2 +-
 config.mak.dev                      |  1 -
 t/unit-tests/t-reftable-readwrite.c |  2 +-
 14 files changed, 39 insertions(+), 33 deletions(-)

-Peff

Comments

Jeff King Aug. 28, 2024, 4:12 a.m. UTC | #1 
On Tue, Aug 27, 2024 at 11:57:23PM -0400, Jeff King wrote:

> When applied on 'master', everything should compile cleanly with the new
> warning. There are some new cases introduced in 'next', but I'll send
> separate patches to go on those individual topics.

Those are at:

  https://lore.kernel.org/git/20240828040944.GA4005021@coredump.intra.peff.net/

and:

  https://lore.kernel.org/git/20240828040803.GA4004932@coredump.intra.peff.net/

I double-checked against what's in 'seen', and there's nothing new
there. Of course I won't be surprised if something new pops up while
this topic is cooking, but CI will start catching it in any branch where
this is merged (and the solution is usually pretty obvious).

-Peff