[0/4] Fixes typemissmatch warinigs from msvc

Message

Sören Krecker Dec. 23, 2024, 11:04 a.m. UTC

A smale series of patches to fix some typemissmatch warings from msvc 14.30.
Most of the missmatches a 64 to 32 bit conversion on a 64 bit Windows platform.

I use size_t where the variable values cannot become negative.

Sören Krecker (4):
  add-patch: Fix type missmatch rom msvc
  date.c: Fix type missmatch warings from msvc
  apply.c : Fix type missmatch warings from msvc
  commit.c: Fix type missmatch warings from msvc

 add-patch.c | 44 +++++++++++++++++++++++++-------------------
 apply.c     | 37 +++++++++++++++++++------------------
 apply.h     |  6 +++---
 commit.c    | 10 +++++-----
 date.c      |  6 +++---
 gettext.h   |  2 +-
 6 files changed, 56 insertions(+), 49 deletions(-)


base-commit: ff795a5c5ed2e2d07c688c217a615d89e3f5733b

Comments

Junio C Hamano Dec. 23, 2024, 4:37 p.m. UTC | #1

Sören Krecker <[e-mail]> writes:

> A smale series of patches to fix some typemissmatch warings from msvc 14.30.
> Most of the missmatches a 64 to 32 bit conversion on a 64 bit Windows platform.

Thanks for the patches.

I'll welcome other people to take a look, if they are inclined, but
it is not something I'd want to look at during a pre-release freeze.
Nobody sane would be running "git add -p" on a patch that exceeds
2GB, for example, so the only practical thing they fix are compiler
warnings.  They are worth fixing eventually, but not all that
urgent.

Thanks, again.

Junio C Hamano Dec. 23, 2024, 4:52 p.m. UTC | #2

Junio C Hamano <[e-mail]> writes:

> Sören Krecker <[e-mail]> writes:
>
>> A smale series of patches to fix some typemissmatch warings from msvc 14.30.
>> Most of the missmatches a 64 to 32 bit conversion on a 64 bit Windows platform.
>
> Thanks for the patches.
>
> I'll welcome other people to take a look, if they are inclined, but
> it is not something I'd want to look at during a pre-release freeze.
> Nobody sane would be running "git add -p" on a patch that exceeds
> 2GB, for example, so the only practical thing they fix are compiler
> warnings.  They are worth fixing eventually, but not all that
> urgent.
>
> Thanks, again.

Oops, sorry, this didn't come out quite right.  I didn't mean to say
that this contribution is unwelcome.  I'll get to it eventually
(like, after the upcoming release), but please do not expect them to
be merged before the upcoming release.