[00/10] Fix segfaults when using the unsafe SHA1 backend

Message

Patrick Steinhardt Dec. 30, 2024, 2:24 p.m. UTC

Hi,

this patch series fixes two segfaults when using the unsafe SHA1
backend. The segfaults are caused by us mixing safe and unsafe variants
of the API. As such, it only surfaces when actually building Git with an
unsafe backend that is different from the safe one.

I noticed those errors while wiring up the build option in the Meson
build system. As such, this patch series doesn't only fix the segfaults,
but also includes patches for the Meson infrastructure and is structured
as follows:

  - Patches 1 and 2 fix the segfaults.

  - Patch 3 makes the segfaults visible via our CI.

  - Patches 4 to 10 wire up the build infrastructure in Meson.

Given that we're close to the release of Git v2.48 I'd be fine with
merging just the first three patches. I can then re-send the Meson stuff
early in the next development cycle.

Thanks!

Patrick

---
Patrick Steinhardt (10):
      bulk-checkin: fix segfault with unsafe SHA1 backend
      builtin/fast-import: fix segfault with unsafe SHA1 backend
      ci: exercise unsafe OpenSSL backend
      meson: consistenlty spell 'CommonCrypto'
      meson: deduplicate access to SHA1/SHA256 backend options
      meson: require SecurityFramework when it's used as SHA1 backend
      meson: simplify conditions for HTTPS and SHA1 dependencies
      meson: add missing dots for build options
      meson: wire up unsafe SHA1 backend
      meson: provide a summary of configured backends

 builtin/fast-import.c     |  2 +-
 bulk-checkin.c            |  2 +-
 ci/run-build-and-tests.sh |  1 +
 meson.build               | 51 ++++++++++++++++++++++++++++++++++++-----------
 meson_options.txt         |  8 +++++---
 5 files changed, 47 insertions(+), 17 deletions(-)


---
base-commit: 306ab352f4e98f6809ce52fc4e5d63fb947d0635
change-id: 20241230-pks-meson-sha1-unsafe-03c785824eee