| Message ID | 20250116161559.91038-1-kuforiji98@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | t/unit-tests: convert unit-tests to use clar | expand |
On Thu, Jan 16, 2025 at 05:15:55PM +0100, Seyi Kuforiji wrote: > Range-diff against v1: > 1: 00bb4d2880 = 1: 00bb4d2880 t/unit-tests: handle dashes in test suite filenames > 2: 59abf45f08 = 2: 59abf45f08 t/unit-tests: convert mem-pool test to use clar test framework > 3: 6e01da141d = 3: 6e01da141d t/unit-tests: adapt priority queue test to use clar test framework > 4: b397a5f131 = 4: b397a5f131 t/unit-tests: convert reftable tree test to use clar test framework I think you passed wrong commit ranges for the range-diff :) Anyway, I scanned through the changes and saw that all my feedback was addressed. I've got one more proposal for the first commit message, but other than that the series looks good to me. Thanks! Patrick
Hello,
This small patch series transitions the existing unit test files to the
Clar testing framework. This change is part of our ongoing effort to
standardize our testing approach and enhance maintainability.
changes in v3:
- Some small fixes were made to the commit messages
Thanks
Seyi
Mentored-by: Patrick Steinhardt ps@pks.im
Signed-off-by: Seyi Kuforiji kuforiji98@gmail.com
Seyi Kuforiji (4):
t/unit-tests: handle dashes in test suite filenames
t/unit-tests: convert mem-pool test to use clar test framework
t/unit-tests: adapt priority queue test to use clar test framework
t/unit-tests: convert reftable tree test to use clar test framework
Makefile | 6 +-
t/meson.build | 6 +-
t/unit-tests/generate-clar-decls.sh | 1 +
t/unit-tests/t-mem-pool.c | 31 ----------
t/unit-tests/t-prio-queue.c | 91 ----------------------------
t/unit-tests/t-reftable-tree.c | 86 --------------------------
t/unit-tests/u-mem-pool.c | 25 ++++++++
t/unit-tests/u-prio-queue.c | 94 +++++++++++++++++++++++++++++
t/unit-tests/u-reftable-tree.c | 78 ++++++++++++++++++++++++
9 files changed, 204 insertions(+), 214 deletions(-)
delete mode 100644 t/unit-tests/t-mem-pool.c
delete mode 100644 t/unit-tests/t-prio-queue.c
delete mode 100644 t/unit-tests/t-reftable-tree.c
create mode 100644 t/unit-tests/u-mem-pool.c
create mode 100644 t/unit-tests/u-prio-queue.c
create mode 100644 t/unit-tests/u-reftable-tree.c
Range-diff against v2:
1: 00bb4d2880 ! 1: f9e163a181 t/unit-tests: handle dashes in test suite filenames
@@ Metadata
## Commit message ##
t/unit-tests: handle dashes in test suite filenames
- The script is designed to extract function signatures that match a
- specific pattern derived from the unit test file's name.
- `generate-clar-decls.sh` does not pick up dashes in filenames, which
- prevents the scripts from being run.
+ "generate-clar-decls.sh" script is designed to extract function
+ signatures that match a specific pattern derived from the unit test
+ file's name. The script does not know to massage file names with dashes,
+ which will make it search for functions that look like, for example,
+ `test_mem-pool_*`. Having dashes in function names is not allowed
+ though, so these patterns won't ever match a legal function name.
Adapt script to translate dashes (`-`) in test suite filenames to
underscores (`_`) to correctly extract the function signatures and run
-: ---------- > 2: f46438f53e t/unit-tests: convert mem-pool test to use clar test framework
-: ---------- > 3: f5cabebd3a t/unit-tests: adapt priority queue test to use clar test framework
-: ---------- > 4: 5323873612 t/unit-tests: convert reftable tree test to use clar test framework
On Fri, Jan 17, 2025 at 01:29:22PM +0100, Seyi Kuforiji wrote: > Hello, > > This small patch series transitions the existing unit test files to the > Clar testing framework. This change is part of our ongoing effort to > standardize our testing approach and enhance maintainability. > > changes in v3: > - Some small fixes were made to the commit messages Thanks, the series looks good to me now. > Range-diff against v2: > 1: 00bb4d2880 ! 1: f9e163a181 t/unit-tests: handle dashes in test suite filenames > @@ Metadata > ## Commit message ## > t/unit-tests: handle dashes in test suite filenames > > - The script is designed to extract function signatures that match a > - specific pattern derived from the unit test file's name. > - `generate-clar-decls.sh` does not pick up dashes in filenames, which > - prevents the scripts from being run. > + "generate-clar-decls.sh" script is designed to extract function > + signatures that match a specific pattern derived from the unit test > + file's name. The script does not know to massage file names with dashes, > + which will make it search for functions that look like, for example, > + `test_mem-pool_*`. Having dashes in function names is not allowed > + though, so these patterns won't ever match a legal function name. > > Adapt script to translate dashes (`-`) in test suite filenames to > underscores (`_`) to correctly extract the function signatures and run > -: ---------- > 2: f46438f53e t/unit-tests: convert mem-pool test to use clar test framework > -: ---------- > 3: f5cabebd3a t/unit-tests: adapt priority queue test to use clar test framework > -: ---------- > 4: 5323873612 t/unit-tests: convert reftable tree test to use clar test framework The range-diff is still not correct :P Now it seems like you only passed the first commit of your v2 to it, instead of the tip of the v2 branch. Patrick
Hello, This small patch series transitions the existing unit test files to the Clar testing framework. This change is part of our ongoing effort to standardize our testing approach and enhance maintainability. changes in v2: - Some small fixes were made to the commit messages - changes was made to the code format Thanks Seyi Mentored-by: Patrick Steinhardt ps@pks.im Signed-off-by: Seyi Kuforiji kuforiji98@gmail.com Seyi Kuforiji (4): t/unit-tests: handle dashes in test suite filenames t/unit-tests: convert mem-pool test to use clar test framework t/unit-tests: adapt priority queue test to use clar test framework t/unit-tests: convert reftable tree test to use clar test framework Makefile | 6 +- t/meson.build | 6 +- t/unit-tests/generate-clar-decls.sh | 1 + t/unit-tests/t-mem-pool.c | 31 ---------- t/unit-tests/t-prio-queue.c | 91 ---------------------------- t/unit-tests/t-reftable-tree.c | 86 -------------------------- t/unit-tests/u-mem-pool.c | 25 ++++++++ t/unit-tests/u-prio-queue.c | 94 +++++++++++++++++++++++++++++ t/unit-tests/u-reftable-tree.c | 78 ++++++++++++++++++++++++ 9 files changed, 204 insertions(+), 214 deletions(-) delete mode 100644 t/unit-tests/t-mem-pool.c delete mode 100644 t/unit-tests/t-prio-queue.c delete mode 100644 t/unit-tests/t-reftable-tree.c create mode 100644 t/unit-tests/u-mem-pool.c create mode 100644 t/unit-tests/u-prio-queue.c create mode 100644 t/unit-tests/u-reftable-tree.c Range-diff against v1: 1: 00bb4d2880 = 1: 00bb4d2880 t/unit-tests: handle dashes in test suite filenames 2: 59abf45f08 = 2: 59abf45f08 t/unit-tests: convert mem-pool test to use clar test framework 3: 6e01da141d = 3: 6e01da141d t/unit-tests: adapt priority queue test to use clar test framework 4: b397a5f131 = 4: b397a5f131 t/unit-tests: convert reftable tree test to use clar test framework