[0/5] pack-objects: better handling of negative options

Message

Jeff King May 1, 2021, 2:02 p.m. UTC

This series fixes a few problems discussed on the security list, but I
don't think the security implications are that interesting (an attacker
would need to control config or command-line options, which are already
pretty dangerous, and can mostly just cause the process to abort). But
still worth addressing.

Patches 3 and 5 are the interesting ones. The rest are just cleaning up
or improving test coverage.

  [1/5]: t5300: modernize basic tests
  [2/5]: t5300: check that we produced expected number of deltas
  [3/5]: pack-objects: clamp negative window size to 0
  [4/5]: t5316: check behavior of pack-objects --depth=0
  [5/5]: pack-objects: clamp negative depth to 0

 builtin/pack-objects.c      |   4 +
 t/t5300-pack-object.sh      | 265 +++++++++++++++---------------------
 t/t5316-pack-delta-depth.sh |  15 ++
 3 files changed, 126 insertions(+), 158 deletions(-)

-Peff