mbox series

[0/2] -Wunused-parameter clenaups on tb/multi-pack-bitmaps

Message ID YTpms9UnVsx+uu/2@coredump.intra.peff.net (mailing list archive)
Headers show
Series -Wunused-parameter clenaups on tb/multi-pack-bitmaps | expand

Message

Jeff King Sept. 9, 2021, 7:55 p.m. UTC 
Now that tb/multi-pack-bitmaps is in "next", my local -Wunused-parameter
topic noticed a few possible cleanups. Neither is a big deal, and I can
definitely hold them for a larger cleanup. But I thought it might be
worth doing them while they're fresh in our minds.

  [1/2]: pack-bitmap: drop repository argument from prepare_midx_bitmap_git()
  [2/2]: pack-bitmap: drop bitmap_index argument from try_partial_reuse()

 midx.c        | 2 +-
 pack-bitmap.c | 8 +++-----
 pack-bitmap.h | 3 +--
 3 files changed, 5 insertions(+), 8 deletions(-)

-Peff

Comments

Taylor Blau Sept. 9, 2021, 8:46 p.m. UTC | #1 
On Thu, Sep 09, 2021 at 03:55:31PM -0400, Jeff King wrote:
> Now that tb/multi-pack-bitmaps is in "next", my local -Wunused-parameter
> topic noticed a few possible cleanups. Neither is a big deal, and I can
> definitely hold them for a larger cleanup. But I thought it might be
> worth doing them while they're fresh in our minds.

Thanks, I'd be happy to see this picked up while the topic is still in
next. Both of the spots you touched looked good to me (and don't
suddenly become necessary in any of the later series that I'm sitting on).

    Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks,
Taylor