mbox series

[0/2] diff tests: un-flaky and post-gettext-poison cleanup

Message ID cover-0.2-00000000000-20210413T122645Z-avarab@gmail.com (mailing list archive)
Headers show
Series diff tests: un-flaky and post-gettext-poison cleanup | expand

Message

Ævar Arnfjörð Bjarmason April 13, 2021, 12:28 p.m. UTC 
In reply to [1] because they're related post-GETTEXT_POISON cleanup,
but both apply on top of master.

I had a flaky t4013 test with some local WIP code that I hadn't
investigated, as it turns out re-running the test was hiding the
failure. 2/2 fixes that, 1/2 is a minor post-GETTEXT_POISON cleanup.

1. https://lore.kernel.org/git/patch-1.1-f0542cd902c-20210413T121930Z-avarab@gmail.com 

Ævar Arnfjörð Bjarmason (2):
  diff tests: remove redundant case statement
  diff tests: rewrite flakyness-causing test "aid"

 t/t4013-diff-various.sh | 31 +++++++++++++++----------------
 1 file changed, 15 insertions(+), 16 deletions(-)

Comments

Junio C Hamano April 13, 2021, 9:42 p.m. UTC | #1 
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> In reply to [1] because they're related post-GETTEXT_POISON cleanup,
> but both apply on top of master.
>
> I had a flaky t4013 test with some local WIP code that I hadn't
> investigated, as it turns out re-running the test was hiding the
> failure. 2/2 fixes that, 1/2 is a minor post-GETTEXT_POISON cleanup.

I feel somewhat offended to see t4013's "auto preparation of the
expected output" feature (which of course I invented) as "flakey" ;-)
but I agree that was a misfeature.  Thanks for taking a look.