[0/3] commit-graph: make "verify" work with replace refs

Message

Ævar Arnfjörð Bjarmason Oct. 14, 2021, 11:37 p.m. UTC

This changes "commit-graph verify" to ignore replace refs, as
"commit-graph write" already does.

The 3/3 is a rather simple fix, and unblocks another series that wants
to fix the GIT_TEST_COMMIT_GRAPH mode.

1-2/3 are fixes to existing commit-graph tests. I just wanted to use
the "graph_git_two_modes" helper, but it was broken, including in a
way that hid an existing failure in a years-old test.

Glen: I've tested this with your v4 series with that
"GIT_TEST_COMMIT_GRAPH=0" part of the mktag tests removed, and they
pass on top of this with GIT_TEST_COMMIT_GRAPH=true.

Ævar Arnfjörð Bjarmason (3):
  commit-graph tests: fix error-hiding graph_git_two_modes() helper
  commit-graph tests: fix another graph_git_two_modes() helper
  commit-graph: don't consider "replace" objects with "verify"

 builtin/commit-graph.c        |  2 +-
 t/t5318-commit-graph.sh       |  5 +++--
 t/t5324-split-commit-graph.sh | 20 ++++++++++++--------
 3 files changed, 16 insertions(+), 11 deletions(-)