[v5,0/5] add --stdin parsing API, use in pack-objects

Message

Ævar Arnfjörð Bjarmason July 26, 2021, 12:46 p.m. UTC

A trivial re-roll of v4[1] on top of
gitster/bc/rev-list-without-commit-line, which it had a conflict
with. Also includes the s/int/unsigned int/ fixup that Junio applied
on the v4 he picked up.

https://lore.kernel.org/git/[e-mail]/

Ævar Arnfjörð Bjarmason (5):
  upload-pack: run is_repository_shallow() before setup_revisions()
  revision.h: refactor "disable_stdin" and "read_from_stdin"
  revision.[ch]: add a "handle_stdin_line" API
  pack-objects.c: do stdin parsing via revision.c's API
  pack-objects.c: make use of REV_INFO_STDIN_LINE_PROCESS

 builtin/am.c           |  4 +--
 builtin/blame.c        |  2 +-
 builtin/diff-tree.c    |  2 +-
 builtin/pack-objects.c | 61 +++++++++++++++++++-----------------------
 builtin/rev-list.c     |  2 +-
 revision.c             | 39 ++++++++++++++++++++++-----
 revision.h             | 60 +++++++++++++++++++++++++++++++++++++----
 sequencer.c            |  4 +--
 8 files changed, 121 insertions(+), 53 deletions(-)

Range-diff against v4:
1:  f2cc9695306 = 1:  b0c7ec31ca9 upload-pack: run is_repository_shallow() before setup_revisions()
2:  50c3b81820b ! 2:  4e5e6620245 revision.h: refactor "disable_stdin" and "read_from_stdin"
    @@ revision.h: struct rev_info {
     +	 * option?
      	 */
     -	int read_from_stdin;
    -+	int consumed_stdin:1;
    ++	unsigned int consumed_stdin:1;
      
      	/* topo-sort */
      	enum rev_sort_order sort_order;
     @@ revision.h: struct rev_info {
    - 			date_mode_explicit:1,
      			preserve_subject:1,
    - 			encode_email_headers:1;
    + 			encode_email_headers:1,
    + 			include_header:1;
     -	unsigned int	disable_stdin:1;
    ++
      	/* --show-linear-break */
      	unsigned int	track_linear:1,
      			track_first_time:1,
3:  0339af8c39a ! 3:  e3d24bd6e8a revision.[ch]: add a "handle_stdin_line" API
    @@ revision.h: struct rev_info {
      
     @@ revision.h: struct rev_info {
      	 */
    - 	int consumed_stdin:1;
    + 	unsigned int consumed_stdin:1;
      
     +	/*
     +	 * When reading from stdin (see "stdin_handling" above) define
4:  d8080b7fd9c = 4:  4787490a90f pack-objects.c: do stdin parsing via revision.c's API
5:  32a172aa80a = 5:  a8b0976649a pack-objects.c: make use of REV_INFO_STDIN_LINE_PROCESS