From patchwork Wed Jan 16 22:42:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jonathan Tan X-Patchwork-Id: 10767039 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 195E717FB for ; Wed, 16 Jan 2019 22:42:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 071512F00C for ; Wed, 16 Jan 2019 22:42:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED1772F788; Wed, 16 Jan 2019 22:42:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CBA02F00C for ; Wed, 16 Jan 2019 22:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387443AbfAPWmW (ORCPT ); Wed, 16 Jan 2019 17:42:22 -0500 Received: from mail-vs1-f74.google.com ([209.85.217.74]:46582 "EHLO mail-vs1-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732830AbfAPWmW (ORCPT ); Wed, 16 Jan 2019 17:42:22 -0500 Received: by mail-vs1-f74.google.com with SMTP id n87so3392760vsi.13 for ; Wed, 16 Jan 2019 14:42:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=j/4cl3OFL0aL6galZSJbp5c1/8Yrs707s3d8DAsqrTY=; b=BBvyCn8MZ/hkHlhv2xZCmlsxXjOP5a1kFWdwBwiyIzxhAtPsehAO6CKC1tX6YC85Uz 4eMslSNhPSqbiQLgcbfcKuUAmUDjYMicwlnSImyEkrgmQit0ZwE129bRHiIh9QN2FnLv Oo5BWuITDfOgMzPlZWWrf6Mt6oFzSUsmbE/eSe7ahCrY9fuw2cMZ0PWUxDPJEDrL5FKy ObvVRb/ZrFwB2y7l+A0qh/ZpohMYOdUCjC0/JrH31fc0UOwyMvtAXcOvRfz9F/eWjfMu aTqa0J3hLVMithl4hXfhfGJQ1L2N8VcoOqpQysgHXpID5eCsTX1YFYBV6XHVu+igeUUi jQig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=j/4cl3OFL0aL6galZSJbp5c1/8Yrs707s3d8DAsqrTY=; b=DEy8SMVPfSun+AN5HU4hd/WtacybymIwduPlKLYqmkdj7/oosyN3aXKgEQuVfGzHtM R6XBhsIVL83ZyPzE/qRF7chWmvzVlyrLn0w9Kw93Ex8e0zVXWgL9MA7JjcMQQee0PL0b j9Bc7FOOk82IE6QKylByVmP8WV7oLLkk+xye88hNXSnLFcg3W6rklJ5JX3Jhql/Qckp4 ogdLgkF4Seflk4F5B4eAHfIUGjNm0v9cjooR0Mzpg7DD5GLVzRKTzubjhvuDkDHSJ4mp SamcKN3jaAea6e7575sPDFs67/47jen2oAMMDFy5YL8/zyCFcKoK1nIb2E3PoDMQjch6 bRZg== X-Gm-Message-State: AJcUukczqJu9/20eXH+ibqtCIkuiQp31MOKcrCrUuDhzZxOnPcmtImlE sfOIwK+/f0p19kSNQU9So6x1FyB/rKWTNfj9dtPvXyNOo7XhbzxZv10+d/48oa3HetXLTekeHZN ZfXiB5zSbbjsjQC4LuUIrJjCk9TkQs0OpTw1g8wO6NSG4SqSClVlH/4vWNY9zFztElrst3QKSwp do X-Google-Smtp-Source: ALg8bN6ea48AxJXKJgKoVlxePfweFYbesq1YVaLufjifIi5nE2yE96lcqFxd5Qn6UBXErtxSlXfS9sN2Y1R+g0zrv0x8 X-Received: by 2002:a1f:9d53:: with SMTP id g80mr6911060vke.3.1547678541218; Wed, 16 Jan 2019 14:42:21 -0800 (PST) Date: Wed, 16 Jan 2019 14:42:08 -0800 Message-Id: Mime-Version: 1.0 X-Mailer: git-send-email 2.19.0.271.gfe8321ec05.dirty Subject: [WIP 0/8] Trying to revive GIT_TEST_PROTOCOL_VERSION From: Jonathan Tan To: git@vger.kernel.org Cc: Jonathan Tan , avarab@gmail.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Ævar, are you planning to revive GIT_TEST_PROTOCOL_VERSION? I have updated the patchset in light of some new branches that have appeared. This is on master merged with: - jk/proto-v2-hidden-refs-fix - tg/t5570-drop-racy-test - js/protocol-advertise-multi - jt/upload-pack-deepen-relative-proto-v2 - jt/fetch-pack-v2 One notable change I made is that I made this envvar determine the minimum version. So, if GIT_TEST_PROTOCOL_VERSION=1 and the test explicitly states v2, v2 is used (but if GIT_TEST_PROTOCOL_VERISON=2, all use v2). I think this reduces the number of false negatives, since there are quite a few tests that use v2 specific features, and that are already marked as v2. I included one genuine bug fix (the last patch) and the rest are either overspecifications (which I didn't investigate too deeply) or false negatives. There are still some errors when run with GIT_TEST_PROTOCOL_VERSION=2 which I don't think are false negatives - I'll continue to look into them. Jonathan Tan (8): tests: define GIT_TEST_PROTOCOL_VERSION tests: always test fetch of unreachable with v0 t5503: fix overspecification of trace expectation t5512: compensate for v0 only sending HEAD symrefs t5700: only run with protocol version 1 tests: fix protocol version for overspecifications t5552: compensate for v2 filtering ref adv. remote-curl: in v2, fill credentials if needed protocol.c | 17 ++++++++-- remote-curl.c | 9 +++++- t/README | 3 ++ t/t5400-send-pack.sh | 2 +- t/t5500-fetch-pack.sh | 4 ++- t/t5503-tagfollow.sh | 2 +- t/t5512-ls-remote.sh | 18 ++++++++--- t/t5515-fetch-merge-logic.sh | 4 +++ t/t5516-fetch-push.sh | 22 ++++++++++--- t/t5539-fetch-http-shallow.sh | 5 ++- t/t5541-http-push-smart.sh | 14 +++++++-- t/t5551-http-fetch-smart.sh | 47 +++++++++++++++++++++------- t/t5552-skipping-fetch-negotiator.sh | 5 ++- t/t5700-protocol-v1.sh | 3 ++ t/t7406-submodule-update.sh | 5 ++- 15 files changed, 128 insertions(+), 32 deletions(-)