[v5,00/10] Filter combination

Message

Matthew DeVore June 27, 2019, 10:54 p.m. UTC

This applies suggestions made by Jonathan Tan, as well as fixes a
Coccinelle-breaking error in strbuf usage, and makes an additional string
localizable.

Thanks,

Matthew DeVore (10):
  list-objects-filter: encapsulate filter components
  list-objects-filter: put omits set in filter struct
  list-objects-filter-options: always supply *errbuf
  list-objects-filter: implement composite filters
  list-objects-filter-options: move error check up
  list-objects-filter-options: make filter_spec a string_list
  strbuf: give URL-encoding API a char predicate fn
  list-objects-filter-options: allow mult. --filter
  list-objects-filter-options: clean up use of ALLOC_GROW
  list-objects-filter-options: make parser void

 Documentation/rev-list-options.txt  |  16 ++
 builtin/clone.c                     |   8 +-
 builtin/fetch.c                     |   9 +-
 builtin/rev-list.c                  |   6 +-
 cache.h                             |  22 ++
 credential-store.c                  |   9 +-
 fetch-pack.c                        |  20 +-
 http.c                              |   6 +-
 list-objects-filter-options.c       | 267 ++++++++++++++++++----
 list-objects-filter-options.h       |  57 ++++-
 list-objects-filter.c               | 335 +++++++++++++++++++++-------
 list-objects-filter.h               |  40 ++--
 list-objects.c                      |  55 ++---
 strbuf.c                            |  15 +-
 strbuf.h                            |   7 +-
 t/t5616-partial-clone.sh            |  19 ++
 t/t6112-rev-list-filters-objects.sh | 194 +++++++++++++++-
 transport-helper.c                  |  10 +-
 transport.c                         |   1 +
 upload-pack.c                       |  13 +-
 url.c                               |   6 +
 url.h                               |   8 +
 22 files changed, 884 insertions(+), 239 deletions(-)

Comments

Junio C Hamano June 28, 2019, 4:05 p.m. UTC | #1

Matthew DeVore <[e-mail]> writes:

> This applies suggestions made by Jonathan Tan, as well as fixes a
> Coccinelle-breaking error in strbuf usage, and makes an additional string
> localizable.

OK, so the convention is that errbuf has already translated string,
so the call to die() made in a fairly high point in the callchain do
not use _().  I looked at the new _() in deeper level of the
callchain this round adds relative to the previous one, and they all
looked sensible.

The helper function should_delegate is now gone---it had only one
callsite in the previous round, so I suspect the resulting code
would be the same either way with moderately decent compilers.

Will queue; thanks.

Jonathan Tan June 28, 2019, 5:16 p.m. UTC | #2

> This applies suggestions made by Jonathan Tan, as well as fixes a
> Coccinelle-breaking error in strbuf usage, and makes an additional string
> localizable.
> 
> Thanks,
> 
> Matthew DeVore (10):
>   list-objects-filter: encapsulate filter components
>   list-objects-filter: put omits set in filter struct
>   list-objects-filter-options: always supply *errbuf
>   list-objects-filter: implement composite filters
>   list-objects-filter-options: move error check up
>   list-objects-filter-options: make filter_spec a string_list
>   strbuf: give URL-encoding API a char predicate fn
>   list-objects-filter-options: allow mult. --filter
>   list-objects-filter-options: clean up use of ALLOC_GROW
>   list-objects-filter-options: make parser void

Thanks - the range-diff looks good to me. (I generated the range diff using a
base of a6a95cd1b4 for v4 and 8dca754b1 for v5.)