[v2,0/4] Fix Sparse Warning

Message

Đoàn Trần Công Danh April 24, 2020, 3:12 p.m. UTC

Change in v2 from v1:
* = { 0 } is an idiom to zero the structure, it shouldn't be changed
* change in [4/4] for prototype
* ignore diffent function prototype

Đoàn Trần Công Danh (4):
  test-parse-pathspec-file.c: s/0/NULL/ for pointer type
  compat/regex: include alloca.h before undef it
  graph.c: limit linkage of internal variable
  progress.c: silence cgcc suggestion about internal linkage

 compat/regex/regex.c                | 1 +
 graph.c                             | 2 +-
 progress.c                          | 2 +-
 progress.h                          | 8 ++++++++
 t/helper/test-parse-pathspec-file.c | 6 +++---
 t/helper/test-progress.c            | 9 +--------
 6 files changed, 15 insertions(+), 13 deletions(-)

Comments

Ramsay Jones April 24, 2020, 4:40 p.m. UTC | #1

On 24/04/2020 16:12, Đoàn Trần Công Danh wrote:
> Change in v2 from v1:
> * = { 0 } is an idiom to zero the structure, it shouldn't be changed
> * change in [4/4] for prototype
> * ignore diffent function prototype

Apart from the regex patch [2/4], these all look good to me.

Thanks!

ATB,
Ramsay Jones

> 
> Đoàn Trần Công Danh (4):
>   test-parse-pathspec-file.c: s/0/NULL/ for pointer type
>   compat/regex: include alloca.h before undef it
>   graph.c: limit linkage of internal variable
>   progress.c: silence cgcc suggestion about internal linkage
> 
>  compat/regex/regex.c                | 1 +
>  graph.c                             | 2 +-
>  progress.c                          | 2 +-
>  progress.h                          | 8 ++++++++
>  t/helper/test-parse-pathspec-file.c | 6 +++---
>  t/helper/test-progress.c            | 9 +--------
>  6 files changed, 15 insertions(+), 13 deletions(-)
>