mbox series

[0/2] gitk: fix mix of tabs and spaces in indentation

Message ID cover.1599726439.git.liu.denton@gmail.com (mailing list archive)
Headers show
Series gitk: fix mix of tabs and spaces in indentation | expand

Message

Denton Liu Sept. 10, 2020, 8:27 a.m. UTC 
The source code of gitk has some funny indentation. It uses four spaces
per level indent but uses tabs every other level (eight spaces).
Reindent gitk to just use tabs instead.

This series should be empty with `--ignore-all-space`.

Denton Liu (2):
  gitk: replace spaces with tabs
  gitk: manually fix whitespace errors

 gitk | 20404 ++++++++++++++++++++++++++++-----------------------------
 1 file changed, 10202 insertions(+), 10202 deletions(-)

Comments

Denton Liu Sept. 10, 2020, 8:36 a.m. UTC | #1 
On Thu, Sep 10, 2020 at 01:27:40AM -0700, Denton Liu wrote:
> Denton Liu (2):
>   gitk: replace spaces with tabs

Unfortunately, the patch is too big to be sent by email. It can be
retrieved from https://github.com/Denton-L/git.git
submitted/gitk-whitespace~.

If you don't want to pull it, the commit without the body is included
below. It can be fully reproduced by running the vim commands listed on
the gitk file.

-- >8 --

From: Denton Liu <liu.denton@gmail.com>
Date: Wed, 9 Sep 2020 12:10:51 -0700
Subject: [PATCH 1/2] gitk: replace spaces with tabs
To: Git Mailing List <git@vger.kernel.org>,
    Paul Mackerras <paulus@ozlabs.org>

The source code is a mix of tabs and spaces. The indentation style
currently is four spaces per indent level but uses tabs every other
level (at eight spaces). Fix this inconsistent spacing and tabbing by
just using a tab-indent for everything.

This was done mechanically using the following vim commands:

	:set tabstop=8
	:set expandtab
	:retab
	:set tabstop=4
	:set noexpandtab
	:retab!
	:set tabstop=8

A future commit will manually clean up the code style errors introduced
by this patch.

This patch should be empty with `--ignore-all-space`.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 gitk | 20408 ++++++++++++++++++++++++++++-----------------------------
 1 file changed, 10204 insertions(+), 10204 deletions(-)
Paul Mackerras Sept. 10, 2020, 9:17 a.m. UTC | #2 
On Thu, Sep 10, 2020 at 01:27:40AM -0700, Denton Liu wrote:
> The source code of gitk has some funny indentation. It uses four spaces
> per level indent but uses tabs every other level (eight spaces).
> Reindent gitk to just use tabs instead.

I don't think I want to do this.  I would accept changing all the
indentation to use just spaces - at least that's going to look OK
regardless of the tab width setting.

Paul.