mbox series

[0/3] add: minor --chmod fixes

Message ID cover.1614037664.git.matheus.bernardino@usp.br (mailing list archive)
Headers show
Series add: minor --chmod fixes | expand

Message

Matheus Tavares Feb. 23, 2021, 1:10 a.m. UTC 
The first patch was broken out from [1], to avoid holding it off while
there is still work to do on that series. The other two are minor
related changes.

[1]: https://lore.kernel.org/git/cover.1613593946.git.matheus.bernardino@usp.br/

Matheus Tavares (3):
  add --chmod: don't update index when --dry-run is used
  add: mark --chmod error string for translation
  add: propagate --chmod errors to exit status

 builtin/add.c  | 18 +++++++++++++-----
 t/t3700-add.sh | 46 +++++++++++++++++++++++++++++++++++++++++-----
 2 files changed, 54 insertions(+), 10 deletions(-)

Comments

Taylor Blau Feb. 23, 2021, 5:08 p.m. UTC | #1 
Hi Matheus,

On Mon, Feb 22, 2021 at 10:10:32PM -0300, Matheus Tavares wrote:
> The first patch was broken out from [1], to avoid holding it off while
> there is still work to do on that series. The other two are minor
> related changes.
>
> [1]: https://lore.kernel.org/git/cover.1613593946.git.matheus.bernardino@usp.br/

All look quite reasonable to me, thanks.

  Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks,
Taylor
Junio C Hamano Feb. 23, 2021, 6:15 p.m. UTC | #2 
Taylor Blau <me@ttaylorr.com> writes:

> Hi Matheus,
>
> On Mon, Feb 22, 2021 at 10:10:32PM -0300, Matheus Tavares wrote:
>> The first patch was broken out from [1], to avoid holding it off while
>> there is still work to do on that series. The other two are minor
>> related changes.
>>
>> [1]: https://lore.kernel.org/git/cover.1613593946.git.matheus.bernardino@usp.br/
>
> All look quite reasonable to me, thanks.
>
>   Reviewed-by: Taylor Blau <me@ttaylorr.com>

Yeah, thanks, both.