| Message ID | cover.1615856156.git.liu.denton@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Sort lists and add static-analysis | expand |
On 16/03/21 07.56, Denton Liu wrote: > As a follow-up to [0], sort some file lists and create a static-analysis > check to ensure that those lists don't ever become un-sorted. > > [0]: https://lore.kernel.org/git/nycvar.QRO.7.76.6.2010081156350.50@tvgsbejvaqbjf.bet/ Remark for future patches that touch these file lists: please try to keep the ASCII sort order when adding something. But anyways, grazie Denton. > Denton Liu (7): > Makefile: mark 'check-builtins' as a .PHONY target > Makefile: ASCII-sort LIB_OBJS > builtin.h: ASCII-sort list of functions > test-tool.h: ASCII-sort list of functions > Makefile: add 'check-sort' target > ci/run-static-analysis.sh: make check-builtins > ci/run-static-analysis.sh: make check-sort > > Makefile | 30 ++++++++++++++++++++++++++++-- > builtin.h | 22 +++++++++++----------- > check-sort.perl | 31 +++++++++++++++++++++++++++++++ > ci/run-static-analysis.sh | 2 +- > t/helper/test-tool.h | 6 +++--- > 5 files changed, 74 insertions(+), 17 deletions(-) > create mode 100755 check-sort.perl >
Denton Liu <liu.denton@gmail.com> writes: > As a follow-up to [0], sort some file lists and create a static-analysis > check to ensure that those lists don't ever become un-sorted. > > [0]: https://lore.kernel.org/git/nycvar.QRO.7.76.6.2010081156350.50@tvgsbejvaqbjf.bet/ > > Denton Liu (7): > Makefile: mark 'check-builtins' as a .PHONY target > Makefile: ASCII-sort LIB_OBJS > builtin.h: ASCII-sort list of functions > test-tool.h: ASCII-sort list of functions > Makefile: add 'check-sort' target > ci/run-static-analysis.sh: make check-builtins > ci/run-static-analysis.sh: make check-sort I'd expect that the series would be structured better if we - move #6 (static-analysis runs check-builtins) earlier, perhaps to the front of the series, as there is nothing to fix to make the check pass. - merge #7 into #5. I've also left comments on a few individual steps. Thanks for working on it. > Makefile | 30 ++++++++++++++++++++++++++++-- > builtin.h | 22 +++++++++++----------- > check-sort.perl | 31 +++++++++++++++++++++++++++++++ > ci/run-static-analysis.sh | 2 +- > t/helper/test-tool.h | 6 +++--- > 5 files changed, 74 insertions(+), 17 deletions(-) > create mode 100755 check-sort.perl