[0/4] midx: trace2 regions and grab-bag patches

Message

Taylor Blau Oct. 12, 2022, 10:01 p.m. UTC

Here is a small handful of MIDX and MIDX bitmap-related patches that
I've been carrying in GitHub's fork for a while now and forgot to send
upstream.

The first is a small typofix, and the second is a legitimate bug fix
which allows us to consider annotated tags as bitmap candidates during
commit selection. The final two are trace2 regions and instrumentation
that I've found helpful when rolling out MIDX bitmaps in a production
setting.

Sorry that these are so disjointed in nature ;-). I figured that it was
better to send a grab-bag series like this than to hold onto these
patches forever!

Thanks in advance for your review.

Taylor Blau (4):
  midx.c: fix whitespace typo
  midx.c: consider annotated tags during bitmap selection
  midx.c: instrument MIDX and bitmap generation with trace2 regions
  pack-bitmap-write.c: instrument number of reused bitmaps

 midx.c                        | 34 +++++++++++++++++++++++++++++++++-
 pack-bitmap-write.c           |  8 +++++++-
 t/t5326-multi-pack-bitmaps.sh | 24 ++++++++++++++++++++++++
 3 files changed, 64 insertions(+), 2 deletions(-)

Comments

Derrick Stolee Oct. 13, 2022, 1:10 p.m. UTC | #1

On 10/12/2022 6:01 PM, Taylor Blau wrote:
> Here is a small handful of MIDX and MIDX bitmap-related patches that
> I've been carrying in GitHub's fork for a while now and forgot to send
> upstream.
> 
> The first is a small typofix, and the second is a legitimate bug fix
> which allows us to consider annotated tags as bitmap candidates during
> commit selection. The final two are trace2 regions and instrumentation
> that I've found helpful when rolling out MIDX bitmaps in a production
> setting.
> 
> Sorry that these are so disjointed in nature ;-). I figured that it was
> better to send a grab-bag series like this than to hold onto these
> patches forever!

As advertised, this set of patches are all nice and small. I've found
the additional tracing useful during performance investigations and
unobtrusive otherwise.

Though they looked familiar, I gave them a careful read and have no
comments. LGTM.

Thanks,
-Stolee

Junio C Hamano Oct. 13, 2022, 8:35 p.m. UTC | #2

Derrick Stolee <[e-mail]> writes:

> On 10/12/2022 6:01 PM, Taylor Blau wrote:
>> Here is a small handful of MIDX and MIDX bitmap-related patches that
>> I've been carrying in GitHub's fork for a while now and forgot to send
>> upstream.
>> 
>> The first is a small typofix, and the second is a legitimate bug fix
>> which allows us to consider annotated tags as bitmap candidates during
>> commit selection. The final two are trace2 regions and instrumentation
>> that I've found helpful when rolling out MIDX bitmaps in a production
>> setting.
>> 
>> Sorry that these are so disjointed in nature ;-). I figured that it was
>> better to send a grab-bag series like this than to hold onto these
>> patches forever!
>
> As advertised, this set of patches are all nice and small. I've found
> the additional tracing useful during performance investigations and
> unobtrusive otherwise.
>
> Though they looked familiar, I gave them a careful read and have no
> comments. LGTM.

Yeah, they look good to me, too.

Thanks, both.