[v2,0/8] repack: fix geometric repacking with gitalternates

Message

Patrick Steinhardt April 12, 2023, 10:22 a.m. UTC

Hi,

this is the second version of my patch to fix geometric repacking with
repositories that are connected to an alternate object database.
Following the discussion with Taylor and Derrick this series goes into
much more detail than the first version and fixes a bunch of issues all
related to geometric repacking.

Patrick

Patrick Steinhardt (8):
  midx: fix segfault with no packs and invalid preferred pack
  repack: fix trying to use preferred pack in alternates
  repack: fix generating multi-pack-index with only non-local packs
  pack-objects: fix error when packing same pack twice
  pack-objects: fix error when same packfile is included and excluded
  pack-objects: extend test coverage of `--stdin-packs` with alternates
  repack: honor `-l` when calculating pack geometry
  repack: disable writing bitmaps when doing a local geometric repack

 builtin/pack-objects.c        |  10 +-
 builtin/repack.c              |  65 +++++++++++--
 midx.c                        |   6 ++
 t/t5319-multi-pack-index.sh   |  11 +++
 t/t5331-pack-objects-stdin.sh | 103 +++++++++++++++++++++
 t/t7703-repack-geometric.sh   | 166 ++++++++++++++++++++++++++++++++++
 6 files changed, 349 insertions(+), 12 deletions(-)
 create mode 100755 t/t5331-pack-objects-stdin.sh

Comments

Taylor Blau April 12, 2023, 10:02 p.m. UTC | #1

On Wed, Apr 12, 2023 at 12:22:27PM +0200, Patrick Steinhardt wrote:
> Patrick Steinhardt (8):
>   midx: fix segfault with no packs and invalid preferred pack
>   repack: fix trying to use preferred pack in alternates
>   repack: fix generating multi-pack-index with only non-local packs
>   pack-objects: fix error when packing same pack twice
>   pack-objects: fix error when same packfile is included and excluded
>   pack-objects: extend test coverage of `--stdin-packs` with alternates
>   repack: honor `-l` when calculating pack geometry
>   repack: disable writing bitmaps when doing a local geometric repack

This is looking like it's on a good track. I gave this a fairly thorough
review, and left a handful of comments ranging from "you could do it
this way, or not", to "we should probably adjust this before merging".

Let me know if you have any questions, and I'll be more than happy to
review a v2 ;-).

Thanks,
Taylor