| Message ID | cover.1689789226.git.me@ttaylorr.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | commit-graph: avoid looking at Bloom filter data directly | expand |
Taylor Blau <me@ttaylorr.com> writes: > The first three are preparatory, but the fourth patch should allow us to > drop the Perl hackery necessary to dump the raw contents of arbitrary > Bloom filters. > > Feel free to pick up these patches (or not), just wanted to get these > out there as a possible suggestion. Thanks, these seem like a good thing to do. Would love to see an updated version with them rolled in. Thanks both for working so well together. > > Taylor Blau (4): > t/helper/test-read-graph.c: extract `dump_graph_info()` > bloom.h: make `load_bloom_filter_from_graph()` public > t/helper/test-read-graph: implement `bloom-filters` mode > fixup! t4216: test changed path filters with high bit paths > > bloom.c | 6 ++-- > bloom.h | 5 +++ > t/helper/test-read-graph.c | 67 ++++++++++++++++++++++++++++++-------- > t/t4216-log-bloom.sh | 14 ++------ > 4 files changed, 64 insertions(+), 28 deletions(-) > > -- > 2.41.0.366.g215419bf3c2.dirty
Taylor Blau <me@ttaylorr.com> writes: > Hi Jonathan, > > Here's a few commits (and one fixup!) that could go before the second > patch of your series, with the fixup! getting squashed into the second > patch itself. > > The first three are preparatory, but the fourth patch should allow us to > drop the Perl hackery necessary to dump the raw contents of arbitrary > Bloom filters. > > Feel free to pick up these patches (or not), just wanted to get these > out there as a possible suggestion. Ah, thanks! I'm on the fence myself about whether this really needs to be more rigorous (the Perl part just gives us an offset; we still check that what's at the offset is correct) but since you have written the patches already, I'll just include them.