[v2,0/2] pack-objects: enable multi-pack reuse via feature.experimental

Message

Taylor Blau Feb. 5, 2024, 10:50 p.m. UTC

Here is a small reroll of my series to teache pack-objects to perform
multi-pack reuse by way of the feature.experimental configuration.

Similar to last time, the hope is that this will expose this new feature
to more users who might not otherwise be aware of lesser-known
configuration options for pack-objects's internals.

The only changes since last time are as follows:

  - Rebased forward onto 2a540e432f (The thirteenth batch, 2024-02-02).

  - Re-introduced a missing `--delta-base-offset` argument into the new
    helper function added and used by t5332.

Thanks in advance for your review!

Taylor Blau (2):
  t5332-multi-pack-reuse.sh: extract pack-objects helper functions
  pack-objects: enable multi-pack reuse via `feature.experimental`

 Documentation/config/feature.txt |  3 ++
 builtin/pack-objects.c           |  2 +
 repo-settings.c                  |  1 +
 repository.h                     |  1 +
 t/t5332-multi-pack-reuse.sh      | 85 +++++++++++++++++---------------
 5 files changed, 51 insertions(+), 41 deletions(-)

Range-diff against v1:
1:  94dd41e1af ! 1:  db3d67bfa3 t5332-multi-pack-reuse.sh: extract pack-objects helper functions
    @@ t/t5332-multi-pack-reuse.sh: pack_position () {
     +test_pack_objects_reused_all () {
     +	: >trace2.txt &&
     +	GIT_TRACE2_EVENT="$PWD/trace2.txt" \
    -+		git pack-objects --stdout --revs --all >/dev/null &&
    ++		git pack-objects --stdout --revs --all --delta-base-offset \
    ++		>/dev/null &&
     +
     +	test_pack_reused "$1" <trace2.txt &&
     +	test_packs_reused "$2" <trace2.txt
2:  a2d0af562a = 2:  683ffd154e pack-objects: enable multi-pack reuse via `feature.experimental`

base-commit: 2a540e432fe5dff3cfa9d3bf7ca56db2ad12ebb9