From patchwork Thu Jun 6 06:30:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 13687850 Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87BF23D56D for ; Thu, 6 Jun 2024 06:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.146 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717655428; cv=none; b=qEFbahN5S1ko5SM4EWeh/uXRy2r/dZAyXpjosSTvtQ1GE3cZiaYEx9b9cQZJcpPKxw2am7sNUYQPLjMHrYgXd6GU1jHG4m1QpduG3y/Bwx2ls57M4j5ribyK7KTwC/c8WEv23tnAOsRHKOGx7IfQuPfIHEkCwFlg7b9V0o4gZfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717655428; c=relaxed/simple; bh=jvfyN3OUvnI6NDuO1jlVBiwIJep6w4pr/edHdjKc5ok=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=WraBpZZ8czLuUVPx5y/dQKbMygZuwzOq8RchNZhGSV7UkMZipkvtU6AYm7FsCFjeJNsS0rEZm9/bKI0YfA5iNzg5Sx0L9riUVd77OZxu/h/92sX4in/1JOShHt8A/DWd2ePlj7l1FEkg1rOJViGp91CgUZTzqJYEpw7ftpyEhiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=pks.im; spf=pass smtp.mailfrom=pks.im; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b=hzz1GwUU; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=g9UaJ0i6; arc=none smtp.client-ip=103.168.172.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="hzz1GwUU"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="g9UaJ0i6" Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id A670A138011F; Thu, 6 Jun 2024 02:30:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 06 Jun 2024 02:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1; t=1717655425; x=1717741825; bh=NtLnwGVOZt0nzCVfATevpK7oxFkZdWfN GVnIJcYCsFk=; b=hzz1GwUUEwtGtX5wXejBwVD+THc4Unqnze14bClN5H2MPd4J NjeyeTrSca2VBM4NuQWL9zoMy4Y0jia5jp/gxce/gIiEHXp8TAi1g5Ducakh722J EjOJAguf+BVEUNqs34SFaK5E8lVTln4WNn0OELrwQpj/mWk99ynWsU0dHoO69/zl O5D1P4xRpDuxvVg6b93xa8ZLHx5rv5MdwUQzqVuPF7orULsGMFpfcw4nTXzbve4F 7yf9vfpNayKq+Dx1Dgkjf2oylVjEC3qfLgDBzExXq6/X6YsFgedQaQMVYF5+SmQ2 gZI+wXOXvDvTmPRerTsTA2dHLb35TNuT6pTthg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1717655425; x=1717741825; bh=NtLnwGVOZt0nzCVfATevpK7oxFkZdWfNGVn IJcYCsFk=; b=g9UaJ0i6y2ZtZ+e1kpNRbd4TIl9BmN2ERUlBOdnnIgpgjVmCnyi CEs4qjebcc+5D0gOkluwOrU8XzkUNzD02bK+jK/BRnqXlVpl2HdivNexUmmkWUE4 v48bwUMY7eRBEH5rffJ1tek7N1fIx8OT1wHtUG+AwIdb01t2MFhi/rM6zPSOrPNU 8wy/Pnu9LdoMsVIZwu6x7ZIGV0gN3ii+65dMSyx+0BAr9iBbNmHV+84gMk1korCt plTxhJev9Grku9z7p+5wKa8tWSCpVT2X+5dBTP+4aqUi1CvEcKgvskaAaV5tEs/l 1SXOgKXrmMZsa4s32EjRKHNCMx7jCRJPBGg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeljedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkgggtugesghdtre ertddtvdenucfhrhhomheprfgrthhrihgtkhcuufhtvghinhhhrghrughtuceophhssehp khhsrdhimheqnecuggftrfgrthhtvghrnhepuefguedtueeiheetleevgedujeekjeehle ejjefhhffghfevgfekueekjedtieejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 Jun 2024 02:30:24 -0400 (EDT) Received: by localhost (OpenSMTPD) with ESMTPSA id adfde936 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 6 Jun 2024 06:29:51 +0000 (UTC) Date: Thu, 6 Jun 2024 08:30:19 +0200 From: Patrick Steinhardt To: git@vger.kernel.org Cc: Jeff King , Junio C Hamano Subject: [PATCH 0/2] ci: detect more warnings via `-Og` Message-ID: Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline Hi, this patch series is triggered by the thread at [1], where Peff noted a potentially-uninitialized variable. In theory, GCC is able to diagnose such issues via `-Wmaybe-uninitialized`. But in practice, this warning is dependent on the optimization level used by GCC, where the issue in the thread is only noticed when compiling with `-Og`. The first patch is just a small fix to our CI I found while at it. The second patch adapts our "pedantic" job to compile with `-Og` so that we overall surface more issues. This would've catched the issue. Patrick [1]: <20240605100728.GA3440281@coredump.intra.peff.net> Patrick Steinhardt (2): ci: fix check for Ubuntu 20.04 ci: let pedantic job compile with -Og ci/lib.sh | 2 +- ci/run-build-and-tests.sh | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-)