[0/3] cache-tree: fix segfaults with invalid cache-trees

Message

Patrick Steinhardt Sept. 17, 2024, 7:13 a.m. UTC

Hi,

this small patch series fixes segfaults that can happen when the index
has a corrupted cache-tree extension. This scenario is covered by t4058,
which documented this segfault. I've noitced that this triggers the leak
sanitizer, so I've decided to fix these segfaults now and handle them
gracefully.

Patrick

Patrick Steinhardt (3):
  cache-tree: refactor verification to return error codes
  cache-tree: detect mismatching number of index entries
  unpack-trees: detect mismatching number of cache-tree/index entries

 cache-tree.c               | 102 ++++++++++++++++++++++++++-----------
 cache-tree.h               |   2 +-
 read-cache.c               |   5 +-
 t/t4058-diff-duplicates.sh |  19 ++++---
 unpack-trees.c             |  12 +++--
 5 files changed, 97 insertions(+), 43 deletions(-)