mbox series

[0/3] doc: merge-tree: improve the script example

Message ID cover.1728298931.git.code@khaugsbakk.name (mailing list archive)
Headers show
Series doc: merge-tree: improve the script example | expand

Message

Kristoffer Haugsbakk Oct. 7, 2024, 11:10 a.m. UTC 
From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>


Kristoffer Haugsbakk (3):
  doc: merge-tree: provide a commit message
  doc: merge-tree: use lower-case variables
  doc: merge-tree: use || directly

 Documentation/git-merge-tree.txt | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

--
2.46.1.641.g54e7913fcb6

Comments

Phillip Wood Oct. 7, 2024, 2:59 p.m. UTC | #1 
Hi Kristoffer

Thanks for working on this. Patches 1 and 3 look like clear improvements 
to me, I've left a comment on patch 2 as the improvement is less clear 
to me but I wouldn't object to it being merged.

Best Wishes

Phillip

On 07/10/2024 12:10, Kristoffer Haugsbakk wrote:
> From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
> 
> 
> Kristoffer Haugsbakk (3):
>    doc: merge-tree: provide a commit message
>    doc: merge-tree: use lower-case variables
>    doc: merge-tree: use || directly
> 
>   Documentation/git-merge-tree.txt | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
> 
> --
> 2.46.1.641.g54e7913fcb6
>
Kristoffer Haugsbakk Oct. 7, 2024, 3 p.m. UTC | #2 
On Mon, Oct 7, 2024, at 16:59, Phillip Wood wrote:
> Hi Kristoffer
>
> Thanks for working on this. Patches 1 and 3 look like clear improvements 
> to me, I've left a comment on patch 2 as the improvement is less clear 
> to me but I wouldn't object to it being merged.
>
> Best Wishes
>
> Phillip

Thanks for taking a look!