mbox series

[v2,0/3] refs: cleanup errno sideband ref related functions.

Message ID pull.1011.v2.git.git.1619191907.gitgitgadget@gmail.com (mailing list archive)
Headers show
Series refs: cleanup errno sideband ref related functions. | expand

Message

Bruce Perry via GitGitGadget April 23, 2021, 3:31 p.m. UTC 
v2:

 * peff's feedback. For now, leave refs.c alone; instead cleanups in
   files-backend and the ref backend API.

Han-Wen Nienhuys (3):
  refs: remove EINVAL specification from the errno sideband in
    read_raw_ref_fn
  refs/files-backend: stop setting errno from lock_ref_oid_basic
  refs: make errno output explicit for read_raw_ref_fn

 refs.c                |  7 +++++--
 refs/debug.c          |  4 ++--
 refs/files-backend.c  | 26 +++++++++-----------------
 refs/packed-backend.c |  5 +++--
 refs/refs-internal.h  | 14 ++++++++------
 5 files changed, 27 insertions(+), 29 deletions(-)


base-commit: 311531c9de557d25ac087c1637818bd2aad6eb3a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1011%2Fhanwen%2Feinval-sideband-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1011/hanwen/einval-sideband-v2
Pull-Request: https://github.com/git/git/pull/1011

Range-diff vs v1:

 1:  ed080f6a9c40 ! 1:  7e8181e77d40 refs: remove EINVAL specification from the errno sideband in read_raw_ref_fn
     @@ Commit message
      
          Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
      
     - ## refs.c ##
     -@@ refs.c: const char *refs_resolve_ref_unsafe(struct ref_store *refs,
     - 	if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
     - 		if (!(resolve_flags & RESOLVE_REF_ALLOW_BAD_NAME) ||
     - 		    !refname_is_safe(refname)) {
     --			errno = EINVAL;
     - 			return NULL;
     - 		}
     - 
     -@@ refs.c: const char *refs_resolve_ref_unsafe(struct ref_store *refs,
     - 		if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
     - 			if (!(resolve_flags & RESOLVE_REF_ALLOW_BAD_NAME) ||
     - 			    !refname_is_safe(refname)) {
     --				errno = EINVAL;
     - 				return NULL;
     - 			}
     - 
     -
       ## refs/refs-internal.h ##
      @@ refs/refs-internal.h: typedef int reflog_expire_fn(struct ref_store *ref_store,
        * properly-formatted or even safe reference name. NEITHER INPUT NOR
 -:  ------------ > 2:  db5da7d7fb51 refs/files-backend: stop setting errno from lock_ref_oid_basic
 -:  ------------ > 3:  7fbc1c754f43 refs: make errno output explicit for read_raw_ref_fn