Message ID | pull.1052.v2.git.git.1626989327.gitgitgadget@gmail.com (mailing list archive) |
---|---|
Headers | show |
Series | Fix direct filesystem access in various test files. | expand |
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:
> This fixes a few test failures in the reftable series.
The early part is already in 'next', and the new ones looked mostly
good.
I didn't quite understand what was going on with "ls -1" though
(what does it even mean to "ls -1" enumerate only the filenames in
.git/reftable directory)?
Thanks.
On Fri, Jul 23, 2021 at 7:44 PM Junio C Hamano <gitster@pobox.com> wrote: > > "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > This fixes a few test failures in the reftable series. > > The early part is already in 'next', and the new ones looked mostly > good. > > I didn't quite understand what was going on with "ls -1" though > (what does it even mean to "ls -1" enumerate only the filenames in > .git/reftable directory)? By listing the files before and after, we can make sure that the ref storage wasn't changed. (perhaps "find -type f" is a better way to do this, though).
Han-Wen Nienhuys <hanwen@google.com> writes: > On Fri, Jul 23, 2021 at 7:44 PM Junio C Hamano <gitster@pobox.com> wrote: >> >> "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes: >> >> > This fixes a few test failures in the reftable series. >> >> The early part is already in 'next', and the new ones looked mostly >> good. >> >> I didn't quite understand what was going on with "ls -1" though >> (what does it even mean to "ls -1" enumerate only the filenames in >> .git/reftable directory)? > > > By listing the files before and after, we can make sure that the ref > storage wasn't changed. Meaning that we rely on the fact that we never append to an existing file? Thanks.
Han-Wen Nienhuys <hanwen@google.com> writes: > On Fri, Jul 23, 2021 at 7:44 PM Junio C Hamano <gitster@pobox.com> wrote: >> >> "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes: >> >> > This fixes a few test failures in the reftable series. >> >> The early part is already in 'next', and the new ones looked mostly >> good. >> >> I didn't quite understand what was going on with "ls -1" though >> (what does it even mean to "ls -1" enumerate only the filenames in >> .git/reftable directory)? > > > By listing the files before and after, we can make sure that the ref > storage wasn't changed. Meaning that we rely on the fact that we never append to an existing file? A comment here would have helped. Thanks.
On Mon, Aug 2, 2021 at 6:28 PM Junio C Hamano <gitster@pobox.com> wrote: > > By listing the files before and after, we can make sure that the ref > > storage wasn't changed. > > Meaning that we rely on the fact that we never append to an existing > file? A comment here would have helped. Added some more explanation. I addressed your comments for the other changes (but forgot to update the cover letter :-/ )