mbox series

[v2,0/6] Allow writing invalid OIDs into refs for testing purposes

Message ID pull.1147.v2.git.git.1638211786.gitgitgadget@gmail.com (mailing list archive)
Headers show
Series Allow writing invalid OIDs into refs for testing purposes | expand

Message

Bruce Perry via GitGitGadget Nov. 29, 2021, 6:49 p.m. UTC 
this covers a few cases of direct filesystem access to the ref database in
tests.

v2 folds in more fixes for making t1430 reftable-proof.

 * add REF_SKIP_REFNAME_VERIFICATION as well
 * upgrade some more bits of t1430

Han-Wen Nienhuys (6):
  test-ref-store: plug memory leak in cmd_delete_refs
  refs: update comment.
  refs: allow skipping OID verification
  refs: add REF_SKIP_REFNAME_VERIFICATION flag
  t1430: remove refs using test-tool
  t1430: create valid symrefs using test-helper

 refs.c                    |  7 +--
 refs.h                    | 16 ++++++-
 refs/files-backend.c      | 53 ++++++++++++----------
 t/helper/test-ref-store.c |  6 ++-
 t/t1006-cat-file.sh       |  5 +--
 t/t1430-bad-ref-name.sh   | 95 ++++++++++++++++++++-------------------
 t/t3800-mktag.sh          |  6 ++-
 7 files changed, 108 insertions(+), 80 deletions(-)


base-commit: 35151cf0720460a897cde9b8039af364743240e7
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1147%2Fhanwen%2Fskip-verification-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1147/hanwen/skip-verification-v2
Pull-Request: https://github.com/git/git/pull/1147

Range-diff vs v1:

 -:  ----------- > 1:  7fa5c247c8b test-ref-store: plug memory leak in cmd_delete_refs
 1:  b83bfda2443 = 2:  82971ddbfcf refs: update comment.
 2:  900cea2ade9 = 3:  93fe3f03fb2 refs: allow skipping OID verification
 -:  ----------- > 4:  0a297f0c3e8 refs: add REF_SKIP_REFNAME_VERIFICATION flag
 -:  ----------- > 5:  06c8ff7df15 t1430: remove refs using test-tool
 -:  ----------- > 6:  3c100702fda t1430: create valid symrefs using test-helper

Comments

Junio C Hamano Nov. 29, 2021, 11:12 p.m. UTC | #1 
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:

> this covers a few cases of direct filesystem access to the ref database in
> tests.
>
> v2 folds in more fixes for making t1430 reftable-proof.
>
>  * add REF_SKIP_REFNAME_VERIFICATION as well
>  * upgrade some more bits of t1430

Thanks, will replace.