mbox series

[0/1] Do use ALL_CFLAGS in hdr-check

Message ID pull.129.git.gitgitgadget@gmail.com (mailing list archive)
Headers show
Series Do use ALL_CFLAGS in hdr-check | expand

Message

Koji Nakamaru via GitGitGadget Aug. 24, 2019, 10:36 p.m. UTC 
When I was playing with the Makefile target hdr-check, it looked as if it
missed the correct CFLAGS. Without them, on Windows an attempt is made to
include syslog.h, which does not make sense at all.

This patch addresses that.

Johannes Schindelin (1):
  hdr-check: make it work on Windows

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: c65a2884eae159bad540135479bc8afe20ff62d1
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-129%2Fdscho%2Ffix-hdr-check-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-129/dscho/fix-hdr-check-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/129

Comments

Junio C Hamano Aug. 26, 2019, 5:04 p.m. UTC | #1 
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> When I was playing with the Makefile target hdr-check, it looked as if it
> missed the correct CFLAGS. Without them, on Windows an attempt is made to
> include syslog.h, which does not make sense at all.

Makes sense.

Thanks.