[0/2] rebase: stricter label lookups

Message

Derrick Stolee via GitGitGadget Nov. 10, 2022, 4:43 p.m. UTC

If a rebase label does not exist and a branch or tag named refs/rewritten/
does exist it will use that instead of returning an error.

Phillip Wood (2):
  sequencer: unify label lookup
  sequencer: tighten label lookups

 sequencer.c              | 53 +++++++++++++++++++++-------------------
 t/t3430-rebase-merges.sh | 17 +++++++++++++
 2 files changed, 45 insertions(+), 25 deletions(-)


base-commit: 3b08839926fcc7cc48cf4c759737c1a71af430c1
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1414%2Fphillipwood%2Fsequencer-label-read-refs-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1414/phillipwood/sequencer-label-read-refs-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1414

Comments

Taylor Blau Nov. 11, 2022, 4:39 a.m. UTC | #1

On Thu, Nov 10, 2022 at 04:43:39PM +0000, Phillip Wood via GitGitGadget wrote:
> If a rebase label does not exist and a branch or tag named refs/rewritten/
> does exist it will use that instead of returning an error.
>
> Phillip Wood (2):
>   sequencer: unify label lookup
>   sequencer: tighten label lookups
>
>  sequencer.c              | 53 +++++++++++++++++++++-------------------
>  t/t3430-rebase-merges.sh | 17 +++++++++++++
>  2 files changed, 45 insertions(+), 25 deletions(-)

Both were a very pleasant read. Thanks for working on this, will queue.

Thanks,
Taylor