| Message ID | pull.1589.v3.git.1700796916.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Switch links to https | expand |
On Thu, Nov 23, 2023 at 7:35 PM Josh Soref via GitGitGadget <gitgitgadget@gmail.com> wrote: > > There are a couple of categories of http links... > > There are four categories worth changing: > > * pages that have jittered a bit but are now available as https: > * pages which exist at both http: and https: and can be safely switched > * pages that have jittered a bit and are not available over https: > * pages that are gone and for which the best source is > https://web.archive.org > > And some categories that aren't being changed: > > * links that are required to be http: because they're copied from something > that mandates it (the apache license, xml namespaces, xsl docbook > things?) > * urls that were imaginary (e.g. http://example.com/repo.git) > * links in borrowed code where the http: form still works > > In order: > > * doc: update links to current pages -- I found the current pages for > these, it should be easy enough to verify these / reject them > * doc: switch links to https -- the simplest > * doc: update links for andre-simon.de -- I've split this out, I don't like > the idea of having to download binaries over http. If this were my > project, I'd be tempted to remove the feature or self-host w/ https... > * doc: refer to internet archive -- the original urls are dead, I've found > internet archive date links for them. (There are some in git already, so > this seemed like a very reasonable choice.) > > Changes from v1: > > * Commit messages have been adjusted since v1 > * files were dropped based on feedback from Junio > > Changes from v2: > > * The first two commits have been swapped (favoring more complicated urls > over simply switching to https) > * The archive.org link for atomenabled.org has been dropped, we'll risk > users getting hacked content from an arbitrary MITM instead of taking > archived authenticated content based on the last time their web site was > properly maintained. As stated elsewhere, I'd be fine with using the archived link if the justification presented in the series for using archived links was consistent and mentioned both reasons for changes. But, I think this series is fine to merge down as-is if you don't want to go through the trouble. Especially given how long you've waited. Anyway, I checked through every link in this series; it all looks good to me.
Elijah Newren wrote: > As stated elsewhere, I'd be fine with using the archived link if the > justification presented in the series for using archived links was > consistent and mentioned both reasons for changes. But, I think this > series is fine to merge down as-is if you don't want to go through the > trouble. Especially given how long you've waited. I'm clearly still contributing, so I can come back later and cross that bridge... > Anyway, I checked through every link in this series; it all looks good to me. Let's take this as-is. Thanks for taking the time to re-check every link, I know exactly how tedious that is :).
Josh Soref <jsoref@gmail.com> writes: > Elijah Newren wrote: >> As stated elsewhere, I'd be fine with using the archived link if the >> justification presented in the series for using archived links was >> consistent and mentioned both reasons for changes. But, I think this >> series is fine to merge down as-is if you don't want to go through the >> trouble. Especially given how long you've waited. > > I'm clearly still contributing, so I can come back later and cross > that bridge... > >> Anyway, I checked through every link in this series; it all looks good to me. > > Let's take this as-is. Thanks for taking the time to re-check every > link, I know exactly how tedious that is :). Thanks, both. Will queue.
There are a couple of categories of http links... There are four categories worth changing: * pages that have jittered a bit but are now available as https: * pages which exist at both http: and https: and can be safely switched * pages that have jittered a bit and are not available over https: * pages that are gone and for which the best source is https://web.archive.org And some categories that aren't being changed: * links that are required to be http: because they're copied from something that mandates it (the apache license, xml namespaces, xsl docbook things?) * urls that were imaginary (e.g. http://example.com/repo.git) * links in borrowed code where the http: form still works In order: * doc: update links to current pages -- I found the current pages for these, it should be easy enough to verify these / reject them * doc: switch links to https -- the simplest * doc: update links for andre-simon.de -- I've split this out, I don't like the idea of having to download binaries over http. If this were my project, I'd be tempted to remove the feature or self-host w/ https... * doc: refer to internet archive -- the original urls are dead, I've found internet archive date links for them. (There are some in git already, so this seemed like a very reasonable choice.) Changes from v1: * Commit messages have been adjusted since v1 * files were dropped based on feedback from Junio Changes from v2: * The first two commits have been swapped (favoring more complicated urls over simply switching to https) * The archive.org link for atomenabled.org has been dropped, we'll risk users getting hacked content from an arbitrary MITM instead of taking archived authenticated content based on the last time their web site was properly maintained. Josh Soref (4): doc: update links to current pages doc: switch links to https doc: update links for andre-simon.de doc: refer to internet archive Documentation/CodingGuidelines | 2 +- Documentation/MyFirstContribution.txt | 2 +- Documentation/RelNotes/1.6.2.txt | 2 +- Documentation/RelNotes/1.6.3.txt | 2 +- Documentation/RelNotes/1.6.4.txt | 2 +- Documentation/RelNotes/1.6.5.txt | 2 +- Documentation/RelNotes/1.6.6.txt | 2 +- Documentation/git-cvsimport.txt | 4 ++-- Documentation/git-format-patch.txt | 4 ++-- Documentation/git-imap-send.txt | 2 +- Documentation/git-send-email.txt | 2 +- Documentation/git.txt | 2 +- Documentation/gitcore-tutorial.txt | 2 +- Documentation/gitprotocol-http.txt | 4 ++-- Documentation/gitweb.conf.txt | 4 ++-- Documentation/gitweb.txt | 2 +- Documentation/howto/keep-canonical-history-correct.txt | 2 +- Documentation/signoff-option.txt | 2 +- INSTALL | 2 +- Makefile | 4 ++-- README.md | 2 +- git-cvsimport.perl | 2 +- git-gui/git-gui.sh | 6 +++--- git-gui/lib/encoding.tcl | 2 +- git-gui/po/README | 2 +- git-instaweb.sh | 4 ++-- gitk-git/gitk | 4 ++-- gitweb/INSTALL | 2 +- gitweb/gitweb.perl | 10 +++++----- gitweb/static/gitweb.css | 2 +- gitweb/static/js/lib/common-lib.js | 10 +++++----- graph.h | 4 ++-- http.c | 2 +- imap-send.c | 4 ++-- json-writer.h | 4 ++-- kwset.c | 2 +- kwset.h | 2 +- list.h | 2 +- perl/FromCPAN/Error.pm | 2 +- perl/Git/SVN.pm | 2 +- protocol.h | 2 +- sh-i18n--envsubst.c | 4 ++-- sha1dc/sha1.c | 2 +- t/README | 4 ++-- t/helper/test-regex.c | 2 +- t/lib-gpg.sh | 2 +- t/perf/perf-lib.sh | 2 +- t/t9114-git-svn-dcommit-merge.sh | 2 +- t/t9801-git-p4-branch.sh | 2 +- t/t9816-git-p4-locked.sh | 2 +- t/test-lib-functions.sh | 2 +- t/test-lib-github-workflow-markup.sh | 2 +- t/test-lib-junit.sh | 2 +- t/test-lib.sh | 2 +- trace.c | 2 +- utf8.c | 2 +- utf8.h | 6 +++--- 57 files changed, 81 insertions(+), 81 deletions(-) base-commit: 564d0252ca632e0264ed670534a51d18a689ef5d Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1589%2Fjsoref%2Fhttps-v3 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1589/jsoref/https-v3 Pull-Request: https://github.com/gitgitgadget/git/pull/1589 Range-diff vs v2: 2: 80eb5da8ed4 ! 1: 54d3861aedf doc: update links to current pages @@ Documentation/git-format-patch.txt: Approach #3 (external editor) The following Thunderbird extensions are needed: -AboutConfig from http://aboutconfig.mozdev.org/ and +-External Editor from http://globs.org/articles.php?lng=en&pg=8 +AboutConfig from https://mjg.github.io/AboutConfig/ and - External Editor from https://globs.org/articles.php?lng=en&pg=8 ++External Editor from https://globs.org/articles.php?lng=en&pg=8 1. Prepare the patch as a text file using your method of choice. + ## Documentation/git.txt ## @@ Documentation/git.txt: Authors @@ gitk-git/gitk: if {[tk windowingsystem] eq "aqua"} { ## gitweb/static/js/lib/common-lib.js ## @@ gitweb/static/js/lib/common-lib.js: function addCssRule(selector, style) { * http://www.dustindiaz.com/getelementsbyclass/ - * https://stackoverflow.com/questions/1818865/do-we-have-getelementsbyclassname-in-javascript + * http://stackoverflow.com/questions/1818865/do-we-have-getelementsbyclassname-in-javascript * - * See also http://ejohn.org/blog/getelementsbyclassname-speed-comparison/ + * See also https://johnresig.com/blog/getelementsbyclassname-speed-comparison/ @@ json-writer.h @@ /* * JSON data structures are defined at: - * [1] https://www.ietf.org/rfc/rfc7159.txt + * [1] http://www.ietf.org/rfc/rfc7159.txt - * [2] http://json.org/ + * [2] https://www.json.org/ * 1: 71ed1286d7f ! 2: cd44658f408 doc: switch links to https @@ Metadata ## Commit message ## doc: switch links to https - It's somewhat traditional to respect sites' self-identification. + These sites offer https versions of their content. + Using the https versions provides some protection for users. Signed-off-by: Josh Soref <jsoref@gmail.com> - ## Documentation/CodingGuidelines ## -@@ Documentation/CodingGuidelines: code. For Git in general, a few rough rules are: - - "Once it _is_ in the tree, it's not really worth the patch noise to - go and fix it up." -- Cf. http://lkml.iu.edu/hypermail/linux/kernel/1001.3/01069.html -+ Cf. https://lkml.iu.edu/hypermail/linux/kernel/1001.3/01069.html - - - Log messages to explain your changes are as important as the - changes themselves. Clearly written code and in-code comments - ## Documentation/MyFirstContribution.txt ## @@ Documentation/MyFirstContribution.txt: Johannes Schindelin to make life as a Git contributor easier for those used to the GitHub PR workflow. It allows contributors to open pull requests against its @@ Documentation/git-cvsimport.txt: Problems related to tags: GIT --- - ## Documentation/git-format-patch.txt ## -@@ Documentation/git-format-patch.txt: Approach #3 (external editor) - - The following Thunderbird extensions are needed: - AboutConfig from http://aboutconfig.mozdev.org/ and --External Editor from http://globs.org/articles.php?lng=en&pg=8 -+External Editor from https://globs.org/articles.php?lng=en&pg=8 - - 1. Prepare the patch as a text file using your method of choice. - - ## Documentation/git-imap-send.txt ## @@ Documentation/git-imap-send.txt: flames ridiculing you if you don't check this. @@ Documentation/gitweb.conf.txt: filesystem (i.e. "$projectroot/$project"), `%h` t ## Documentation/gitweb.txt ## @@ Documentation/gitweb.txt: Gitweb provides a web interface to Git repositories. Its features include: revisions one at a time, viewing the history of the repository. - * Finding commits which commit messages matches given search term. + * Finding commits whose commit messages match a given search term. -See http://repo.or.cz/w/git.git/tree/HEAD:/gitweb/[] for gitweb source code, +See https://repo.or.cz/w/git.git/tree/HEAD:/gitweb/[] for gitweb source code, @@ gitweb/static/js/lib/common-lib.js: function addCssRule(selector, style) { - * http://stackoverflow.com/questions/1818865/do-we-have-getelementsbyclassname-in-javascript + * https://stackoverflow.com/questions/1818865/do-we-have-getelementsbyclassname-in-javascript * - * See also http://ejohn.org/blog/getelementsbyclassname-speed-comparison/ + * See also https://johnresig.com/blog/getelementsbyclassname-speed-comparison/ * ## graph.h ## @@ json-writer.h * JSON data structures are defined at: - * [1] http://www.ietf.org/rfc/rfc7159.txt + * [1] https://www.ietf.org/rfc/rfc7159.txt - * [2] http://json.org/ + * [2] https://www.json.org/ * * The JSON-writer API allows one to build JSON data structures using a 3: 7cfd7b244ea = 3: 649ce9a9bd4 doc: update links for andre-simon.de 4: 9f0bba69492 ! 4: 6d614a00a97 doc: refer to internet archive @@ Commit message ## gitweb/gitweb.perl ## @@ gitweb/gitweb.perl: sub git_feed { - my $format = shift || 'atom'; my $have_blame = gitweb_check_feature('blame'); -- # Atom: http://www.atomenabled.org/developers/syndication/ + # Atom: http://www.atomenabled.org/developers/syndication/ - # RSS: http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ -+ # Atom: https://web.archive.org/web/20230815171113/https://www.atomenabled.org/developers/syndication/ + # RSS: https://web.archive.org/web/20030729001534/http://www.notestips.com/80256B3A007F2692/1/NAMO5P9UPQ if ($format ne 'rss' && $format ne 'atom') { die_error(400, "Unknown web feed format");